The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Dave Young <dyoung@redhat.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	Cyrill Gorcunov <gorcunov@openvz.org>
Subject: Re: [patch 6/8] kcmp selftests: build fix
Date: Sun, 25 Nov 2012 11:02:31 +0800	[thread overview]
Message-ID: <20121125030231.GA2101@darkstar.nay.redhat.com> (raw)
In-Reply-To: <CAOJsxLGQ+UQnFnbcn9oMTUBd0HB+CSfRy_R0Ze2UOJJfR1+K=w@mail.gmail.com>

On Sat, Nov 24, 2012 at 11:41:23AM +0200, Pekka Enberg wrote:
> On Sat, Nov 24, 2012 at 10:29 AM,  <dyoung@redhat.com> wrote:
> > For old glibc there's no the syscall number this tests will cause
> > make run_tests fail.
> > Add a macro to define the number. This should be ok because it will be
> > built in latest kernel source.
> >
> > Signed-off-by: Dave Young <dyoung@redhat.com>
> > ---
> >  tools/testing/selftests/kcmp/kcmp_test.c |    3 +++
> >  1 file changed, 3 insertions(+)
> >
> > --- linux-2.6.orig/tools/testing/selftests/kcmp/kcmp_test.c     2012-11-23 22:37:04.789058192 +0800
> > +++ linux-2.6/tools/testing/selftests/kcmp/kcmp_test.c  2012-11-23 22:38:43.195191747 +0800
> > @@ -17,6 +17,9 @@
> >  #include <sys/stat.h>
> >  #include <sys/wait.h>
> >
> > +#ifndef __NR_kcmp
> > +#define __NR_kcmp 272
> > +#endif
> 
> Is the syscall number really going to be the same across all architectures?

Oh, they are different. self NACK. Please ignore this patch.

> 
> >  static long sys_kcmp(int pid1, int pid2, int type, int fd1, int fd2)
> >  {
> >         return syscall(__NR_kcmp, pid1, pid2, type, fd1, fd2);
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/

  reply	other threads:[~2012-11-25  3:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-24  8:29 [patch 0/8] several selftests fixes dyoung
2012-11-24  8:29 ` [patch 1/8] vm selftests: print failure status instead of cause make error dyoung
2012-11-24  8:29 ` [patch 2/8] mqueue " dyoung
2012-11-24  9:45   ` Pekka Enberg
2012-11-24  8:29 ` [patch 3/8] cpu-hotplug " dyoung
2012-11-24  9:43   ` Pekka Enberg
2012-11-24  8:29 ` [patch 4/8] mem-hotplug " dyoung
2012-11-24  9:42   ` Pekka Enberg
2012-11-24  8:29 ` [patch 5/8] kcmp selftests: make run_tests fix dyoung
2012-11-24  8:29 ` [patch 6/8] kcmp selftests: build fix dyoung
2012-11-24  9:41   ` Pekka Enberg
2012-11-25  3:02     ` Dave Young [this message]
2012-11-24  8:29 ` [patch 7/8] kcmp selftests: print fail status instead of cause make error dyoung
2012-11-24  9:45   ` Pekka Enberg
2012-11-24  8:29 ` [patch 8/8] breakpoint selftests: print failure " dyoung
2012-11-24  9:45   ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121125030231.GA2101@darkstar.nay.redhat.com \
    --to=dyoung@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=gorcunov@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox