From: Samuel Ortiz <sameo@linux.intel.com>
To: Ashish Jangam <ashish.jangam@kpitcummins.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Axel Lin <axel.lin@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org,
David Dajun Chen <dchen@diasemi.com>
Subject: Re: [Patch v1 1/1] mfd: fix for i2c issue DA9052/53 PMIC
Date: Mon, 26 Nov 2012 00:14:07 +0100 [thread overview]
Message-ID: <20121125231407.GK12685@sortiz-mobl> (raw)
In-Reply-To: <1351853246.32389.8.camel@dhruva>
Hi Ashish,
On Fri, Nov 02, 2012 at 04:17:26PM +0530, Ashish Jangam wrote:
> There is an issue where the DA9052/53-AA/BA/BB PMIC either locks up or fails to
> respond following a system Reset. This could result in a second write
> in which the bus writes the current content of the write buffer to address
> of the last I2C access.
>
> The failure case is where this unwanted write transfers incorrect data to
> a critical register.
>
> This patch fixes this issue by following any read or write with a dummy read
> to a safe register address. A safe register address is one where the contents
> will not affect the operation of the system.
>
> Signed-off-by: David Dajun Chen <dchen@diasemi.com>
> Signed-off-by: Ashish Jangam <ashish.jangam@kpitcummins.com>
> ---
> drivers/mfd/da9052-i2c.c | 56 +++++++++++++++++++++++++++++++++++++
> include/linux/mfd/da9052/da9052.h | 47 ++++++++++++++++++++++++++++--
> include/linux/mfd/da9052/reg.h | 3 ++
> 3 files changed, 102 insertions(+), 4 deletions(-)
Applied to my for-linus branch.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2012-11-25 23:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 10:47 [Patch v1 1/1] mfd: fix for i2c issue DA9052/53 PMIC Ashish Jangam
2012-11-25 23:14 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121125231407.GK12685@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=ashish.jangam@kpitcummins.com \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dchen@diasemi.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox