public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joe Millenbach <jmillenbach@gmail.com>
Cc: Alan Cox <alan@linux.intel.com>, Jiri Slaby <jirislaby@gmail.com>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCHv3] tty: Added a CONFIG_TTY option to allow removal of TTY
Date: Mon, 26 Nov 2012 15:38:24 -0800	[thread overview]
Message-ID: <20121126233824.GA8868@kroah.com> (raw)
In-Reply-To: <1353033035-4928-1-git-send-email-jmillenbach@gmail.com>

On Thu, Nov 15, 2012 at 06:30:35PM -0800, Joe Millenbach wrote:
> The option allows you to remove TTY and compile without errors. This
> saves space on systems that won't support TTY interfaces anyway.
> bloat-o-meter output is below.
> 
> The bulk of this patch consists of Kconfig changes adding "depends on
> TTY" to various serial devices and similar drivers that require the TTY
> layer.  Ideally, these dependencies would occur on a common intermediate
> symbol such as SERIO, but most drivers "select SERIO" rather than
> "depends on SERIO", and "select" does not respect dependencies.
> 
> bloat-o-meter output filtered to not show removed entries with awk
> '$3 != "-"' as the list was very long.
> 
> add/remove: 0/385 grow/shrink: 2/18 up/down: 14/-54016 (-54002)
> function                                     old     new   delta
> chr_dev_init                                 193     205     +12
> selinux_setprocattr                         1167    1169      +2
> static.__warned                              557     556      -1
> start_kernel                                 840     835      -5
> proc_root_init                               167     162      -5
> unregister_console                           165     157      -8
> sys_setsid                                   213     205      -8
> sys_vhangup                                   37      21     -16
> daemonize                                    689     673     -16
> t_stop                                        72      54     -18
> t_next                                       129     108     -21
> static.do_acct_process                       838     806     -32
> release_task                                1157    1125     -32
> do_exit                                     2325    2288     -37
> t_start                                      269     221     -48
> static.__func__                            18289   18219     -70
> do_task_stat                                2962    2892     -70
> flush_unauthorized_files                     740     614    -126
> static._rs                                  1440    1280    -160
> static.__key                                8560    8384    -176
> 
> Signed-off-by: Joe Millenbach <jmillenbach@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

This is a nice idea, but I feel it's a bit too late in the 3.8 merge
window cycle for me to add this to linux-next at this point in time.

Can you rediff this once 3.8-rc1 is out and send it to me then?  That
way we can get a lot more testing in linux-next in order to make sure
it's ready for 3.9?

thanks,

greg k-h

  reply	other threads:[~2012-11-26 23:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-16  2:30 [PATCHv3] tty: Added a CONFIG_TTY option to allow removal of TTY Joe Millenbach
2012-11-26 23:38 ` Greg Kroah-Hartman [this message]
2012-11-26 23:44   ` Jiri Slaby
2012-11-27  2:36     ` Joe Millenbach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121126233824.GA8868@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alan@linux.intel.com \
    --cc=jirislaby@gmail.com \
    --cc=jmillenbach@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox