From: Andrew Morton <akpm@linux-foundation.org>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Alexey Dobriyan <adobriyan@gmail.com>,
Pavel Emelyanov <xemul@parallels.com>,
James Bottomley <jbottomley@parallels.com>,
Matthew Helsley <matt.helsley@gmail.com>,
aneesh.kumar@linux.vnet.ibm.com, bfields@fieldses.org,
oleg@redhat.com, rientjes@google.com,
tvrtko.ursulin@onelan.co.uk, linux-kernel@vger.kernel.org,
Andrey Vagin <avagin@openvz.org>
Subject: Re: [patch -mm 4/4] docs: Add documentation about /proc/<pid>/fdinfo/<fd> output
Date: Tue, 27 Nov 2012 14:47:54 -0800 [thread overview]
Message-ID: <20121127144754.5a617e12.akpm@linux-foundation.org> (raw)
In-Reply-To: <20121122212235.690256454@openvz.org>
On Fri, 23 Nov 2012 01:15:26 +0400
Cyrill Gorcunov <gorcunov@openvz.org> wrote:
> Documentation/filesystems/proc.txt | 81 +++++++++++++++++++++++++++++++++++++
Looks good to me. Here's a small tune-up:
--- a/Documentation/filesystems/proc.txt~docs-add-documentation-about-proc-pid-fdinfo-fd-output-fix
+++ a/Documentation/filesystems/proc.txt
@@ -1639,7 +1639,7 @@ if precise results are needed.
This file provides information associated with an opened file. The regular
files have at least two fields -- 'pos' and 'flags'. The 'pos' represents
the current offset of the opened file in decimal form [see lseek(2) for
-details] and the 'flags' denotes octal O_xxx mask the file has been
+details] and 'flags' denotes the octal O_xxx mask the file has been
created with [see open(2) for details].
A typical output is
@@ -1648,7 +1648,7 @@ A typical output is
flags: 0100002
The files such as eventfd, fsnotify, signalfd, epoll among the regular pos/flags
-pair provide additional information peculiar to the objects they represent.
+pair provide additional information particular to the objects they represent.
Eventfd files
~~~~~~~~~~~~~
@@ -1687,17 +1687,18 @@ pair provide additional information pecu
where 'wd' is a watch descriptor in decimal form, ie a target file
descriptor number, 'ino' and 'sdev' are inode and device where the
- target file lays on and the 'mask' is the mask of events, all in hex
+ target file resides and the 'mask' is the mask of events, all in hex
form [see inotify(7) for more details].
- In case if the kernel built with exportfs the path to the target file
- is encoded as a file handle. The file handle provided by three fields
- 'fhandle-bytes', 'fhandle-type' and 'f_handle', all in hex format.
+ If the kernel was built with exportfs support, the path to the target
+ file is encoded as a file handle. The file handle is provided by three
+ fields 'fhandle-bytes', 'fhandle-type' and 'f_handle', all in hex
+ format.
If the kernel is built without exportfs support the file handle won't be
printed out.
- For fanotify files the format is the following
+ For fanotify files the format is
pos: 0
flags: 02
@@ -1709,9 +1710,9 @@ pair provide additional information pecu
flags: 02
fanotify mnt_id:13 mask:1 ignored_mask:40000000
- where 'ino', 'sdev' are target inode and device, 'mnt_id' is the mount point identifier,
- 'mask' is the events mask used and 'ignored_mask' is the mask of events which are
- to be ignored. All written in hex format.
+ where 'ino', 'sdev' are target inode and device, 'mnt_id' is the mount
+ point identifier, 'mask' is the events mask used and 'ignored_mask' is
+ the mask of events which are to be ignored. All in hex format.
------------------------------------------------------------------------------
_
next prev parent reply other threads:[~2012-11-27 22:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 21:15 [patch -mm 0/4] Fixes for fdinfo output and docs Cyrill Gorcunov
2012-11-22 21:15 ` [patch -mm 1/4] fs, notify: Add missing space after prefix Cyrill Gorcunov
2012-11-22 21:15 ` [patch -mm 2/4] fs, epoll: Drop enabled field from fdinfo output Cyrill Gorcunov
2012-11-22 21:15 ` [patch -mm 3/4] fs, notify: Dont forget to provide fhandle for inode fanotify Cyrill Gorcunov
2012-11-22 21:15 ` [patch -mm 4/4] docs: Add documentation about /proc/<pid>/fdinfo/<fd> output Cyrill Gorcunov
2012-11-27 22:47 ` Andrew Morton [this message]
2012-11-28 6:40 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121127144754.5a617e12.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=avagin@openvz.org \
--cc=bfields@fieldses.org \
--cc=gorcunov@openvz.org \
--cc=jbottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.helsley@gmail.com \
--cc=oleg@redhat.com \
--cc=rientjes@google.com \
--cc=tvrtko.ursulin@onelan.co.uk \
--cc=viro@zeniv.linux.org.uk \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox