From: Andrew Morton <akpm@linux-foundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Stefani Seibold <stefani@seibold.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH, resend] kfifo: initialize fifo accordingly to C99 standard
Date: Wed, 28 Nov 2012 17:51:40 -0800 [thread overview]
Message-ID: <20121128175140.46ce7547.akpm@linux-foundation.org> (raw)
In-Reply-To: <1353508271-30646-1-git-send-email-andriy.shevchenko@linux.intel.com>
On Wed, 21 Nov 2012 16:31:11 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> When build a kernel with "make W=1" we will get a warning about missing
> initializer. It comes from kfifo usage style. The DEFINE_KFIFO macro doesn't
> initialize the buf[] field of the fifo structure. So, using C99 style helps in
> such case.
This doesn't actually work:
drivers/pci/pcie/aer/aerdrv_core.c:573: error: unknown field 'kfifo' specified in initializer
drivers/pci/pcie/aer/aerdrv_core.c:573: error: unknown field 'in' specified in initializer
drivers/pci/pcie/aer/aerdrv_core.c:573: warning: missing braces around initializer
drivers/pci/pcie/aer/aerdrv_core.c:573: warning: (near initialization for '(anonymous).<anonymous>.kfifo')
drivers/pci/pcie/aer/aerdrv_core.c:573: error: unknown field 'out' specified in initializer
gcc-4.4.4.
next prev parent reply other threads:[~2012-11-29 1:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 14:31 [PATCH, resend] kfifo: initialize fifo accordingly to C99 standard Andy Shevchenko
2012-11-28 23:56 ` Andrew Morton
2012-11-29 9:21 ` Andy Shevchenko
2012-11-29 12:57 ` Andy Shevchenko
2012-11-29 1:51 ` Andrew Morton [this message]
2012-11-29 13:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121128175140.46ce7547.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefani@seibold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox