Re: [PATCH v2] Do a proper locking for mmap and block size change

Linus Torvalds
2012-11-29T19:26:29Z

On Thu, Nov 29, 2012 at 11:15 AM, Chris Mason <chris.mason@fusionio.com> wrote:
>
> The fs/buffer.c part makes sense during a quick read. But
> fs/direct-io.c plays with i_blkbits too. The semaphore was fixing real
> bugs there.

Ugh. I _hate_ direct-IO. What a mess. And yeah, it seems to be
incestuously playing games that should be in fs/buffer.c. I thought it
was doing the sane thing with the page cache.

(I now realize that Mikulas was talking about this mess, while I
thought he was talking about the AIO code which is largely sane).

Linus