Re: [PATCH v2] Do a proper locking for mmap and block size change

Linus Torvalds
2012-11-29T19:55:33Z

On Thu, Nov 29, 2012 at 11:48 AM, Chris Mason <chris.mason@fusionio.com> wrote:
>
> blkdev_get_blocks (called during DIO) is also checking i_blkbits, but I
> really don't get why that isn't byte based instead. DIO is already
> doing the shift & mask game.

The blkdev_get_blocks() this is just sad.

The underlying data structure is actually byte-based (it's
"i_size_read(bdev->bd_inode"), but we convert it to a block-based
number.

Oops.

Linus