Re: [PATCH v2] Do a proper locking for mmap and block size change

Linus Torvalds
2012-11-30T16:43:19Z

On Fri, Nov 30, 2012 at 6:31 AM, Chris Mason <chris.mason@fusionio.com> wrote:
> On Thu, Nov 29, 2012 at 07:49:10PM -0700, Dave Chinner wrote:
>>
>> Same with mpage_readpages(), so it's not just direct IO that has
>> this problem....
>
> I guess the good news is that block devices don't have readpages. The
> bad news would be that we can't put readpages in without much bigger
> changes.

Well, the new block-dev branch no longer cares. It basically says "ok,
we use inode->i_blkbits, but for raw device accesses we know it's
unstable, so we'll just not use it".

So both mpage_readpages and direct-IO should be happy. And it actually
removed redundant code, so it's all good.

Linus