From: Aristeu Rozanski <aris@redhat.com>
To: "Serge E. Hallyn" <serge@hallyn.com>
Cc: linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Serge Hallyn <serge.hallyn@canonical.com>,
cgroups@vger.kernel.org
Subject: Re: [PATCH 3/5] device_cgroup: keep track of local group settings
Date: Thu, 29 Nov 2012 17:31:11 -0500 [thread overview]
Message-ID: <20121129223111.GZ32112@redhat.com> (raw)
In-Reply-To: <20121129202608.GA26716@mail.hallyn.com>
On Thu, Nov 29, 2012 at 08:26:08PM +0000, Serge E. Hallyn wrote:
> Quoting Aristeu Rozanski (aris@redhat.com):
> > I see your point. it's indeed a problem. in dev_exception_add(), it
> > needs to check for permissions before actually adding to
> > devcgroup->exceptions.
actually, checked again, it's done correctly. when adding an exception
that will allow extra device access (DEVCG_ALLOW), it does check it
before. It means that you can't add local exceptions unless at a certain
point of the time it was allowed to do so.
> >
> > > (Btw is there a git tree or gitweb view I could look at alongside
> > > the patchset?)
> >
> > I'll rebase the patchset along with a fix for this and resubmit with a
> > link to the git repo.
just pushed the same version to:
git://github.com/aristeu/linux-2.6.git
please use branch devcg_hiearchy_review
--
Aristeu
next prev parent reply other threads:[~2012-11-29 22:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 19:35 [PATCH 0/5] devcg: introduce proper hierarchy support Aristeu Rozanski
2012-11-27 19:35 ` [PATCH 1/5] device_cgroup: fix locking in devcgroup_destroy() Aristeu Rozanski
2012-11-29 19:06 ` Serge E. Hallyn
2012-12-03 17:29 ` Tejun Heo
2012-11-27 19:35 ` [PATCH 2/5] device_cgroup: prepare exception list handling functions for two lists Aristeu Rozanski
2012-11-29 19:07 ` Serge E. Hallyn
2012-12-03 17:31 ` Tejun Heo
2012-11-27 19:35 ` [PATCH 3/5] device_cgroup: keep track of local group settings Aristeu Rozanski
2012-11-29 19:29 ` Serge E. Hallyn
2012-11-29 19:59 ` Aristeu Rozanski
2012-11-29 20:26 ` Serge E. Hallyn
2012-11-29 22:31 ` Aristeu Rozanski [this message]
2012-12-03 18:01 ` Serge E. Hallyn
2012-12-03 19:06 ` Aristeu Rozanski
2012-12-06 4:31 ` Serge E. Hallyn
2012-11-29 20:11 ` Aristeu Rozanski
2012-11-27 19:35 ` [PATCH 4/5] device_cgroup: make may_access() stronger Aristeu Rozanski
2012-12-03 17:44 ` Tejun Heo
2012-12-03 19:01 ` Aristeu Rozanski
2012-11-27 19:35 ` [PATCH 5/5] device_cgroup: propagate local changes down the hierarchy Aristeu Rozanski
2012-12-03 18:01 ` Tejun Heo
2012-12-03 19:14 ` Aristeu Rozanski
2012-12-03 21:36 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121129223111.GZ32112@redhat.com \
--to=aris@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=serge.hallyn@canonical.com \
--cc=serge@hallyn.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).