* [PATCH] irqdomain: stop screaming about preallocated irqdescs
@ 2012-11-27 0:20 Linus Walleij
2012-11-30 9:02 ` Grant Likely
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2012-11-27 0:20 UTC (permalink / raw)
To: linux-kernel, Grant Likely, Rob Herring, Thomas Gleixner
Cc: Anmar Oueja, Linus Walleij
From: Linus Walleij <linus.walleij@linaro.org>
In the simple irqdomain: don't shout warnings to the user,
there is no point. An informational print is sufficient.
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
kernel/irq/irqdomain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 4e69e24..96f3a1d 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -177,8 +177,8 @@ struct irq_domain *irq_domain_add_simple(struct device_node *of_node,
irq_base = irq_alloc_descs(first_irq, first_irq, size,
of_node_to_nid(of_node));
if (irq_base < 0) {
- WARN(1, "Cannot allocate irq_descs @ IRQ%d, assuming pre-allocated\n",
- first_irq);
+ pr_info("Cannot allocate irq_descs @ IRQ%d, assuming pre-allocated\n",
+ first_irq);
irq_base = first_irq;
}
} else
--
1.7.11.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] irqdomain: stop screaming about preallocated irqdescs
2012-11-27 0:20 [PATCH] irqdomain: stop screaming about preallocated irqdescs Linus Walleij
@ 2012-11-30 9:02 ` Grant Likely
0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2012-11-30 9:02 UTC (permalink / raw)
To: Linus Walleij, linux-kernel, Rob Herring, Thomas Gleixner
Cc: Anmar Oueja, Linus Walleij
On Tue, 27 Nov 2012 01:20:32 +0100, Linus Walleij <linus.walleij@stericsson.com> wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> In the simple irqdomain: don't shout warnings to the user,
> there is no point. An informational print is sufficient.
>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied, thanks.
g.
> ---
> kernel/irq/irqdomain.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 4e69e24..96f3a1d 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -177,8 +177,8 @@ struct irq_domain *irq_domain_add_simple(struct device_node *of_node,
> irq_base = irq_alloc_descs(first_irq, first_irq, size,
> of_node_to_nid(of_node));
> if (irq_base < 0) {
> - WARN(1, "Cannot allocate irq_descs @ IRQ%d, assuming pre-allocated\n",
> - first_irq);
> + pr_info("Cannot allocate irq_descs @ IRQ%d, assuming pre-allocated\n",
> + first_irq);
> irq_base = first_irq;
> }
> } else
> --
> 1.7.11.3
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-30 9:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-27 0:20 [PATCH] irqdomain: stop screaming about preallocated irqdescs Linus Walleij
2012-11-30 9:02 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).