[PATCH 3/3] mfd: tps65910: fix wrong ack_base register

[PATCH 3/3] mfd: tps65910: fix wrong ack_base register

[Kim, Milo]

 The interrupt status registers of TPS65910/1 should be cleared
 when the associated interrupt event occurs.
 This work is done in the regmap irq thread - using 'ack_base' register.
 The ACK registers should be fixed as status register, not mask registers.

 This patch fixes the infinite interrupt event problem by clearing
 interrupt status registers.

 Tested on the AM3517 Craneboard.

Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
---
 drivers/mfd/tps65910.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index ca37833..fdb3027 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -211,7 +211,7 @@ static struct regmap_irq_chip tps65911_irq_chip = {
 	.irq_reg_stride = 2,
 	.status_base = TPS65910_INT_STS,
 	.mask_base = TPS65910_INT_MSK,
-	.ack_base = TPS65910_INT_MSK,
+	.ack_base = TPS65910_INT_STS,
 };
 
 static struct regmap_irq_chip tps65910_irq_chip = {
@@ -222,7 +222,7 @@ static struct regmap_irq_chip tps65910_irq_chip = {
 	.irq_reg_stride = 2,
 	.status_base = TPS65910_INT_STS,
 	.mask_base = TPS65910_INT_MSK,
-	.ack_base = TPS65910_INT_MSK,
+	.ack_base = TPS65910_INT_STS,
 };
 
 static int tps65910_irq_init(struct tps65910 *tps65910, int irq,
-- 
1.7.9.5

Best Regards,
Milo

Re: [PATCH 3/3] mfd: tps65910: fix wrong ack_base register

[Laxman Dewangan]

On Thursday 29 November 2012 12:12 PM, Kim, Milo wrote:
>   The interrupt status registers of TPS65910/1 should be cleared
>   when the associated interrupt event occurs.
>   This work is done in the regmap irq thread - using 'ack_base' register.
>   The ACK registers should be fixed as status register, not mask registers.
>
>   This patch fixes the infinite interrupt event problem by clearing
>   interrupt status registers.
>
>   Tested on the AM3517 Craneboard.
>
> Signed-off-by: Milo(Woogyom) Kim<milo.kim@ti.com>
> ---

Aah,  I was debugging the onkey and I am also seeing continuous 
interrupt. This fix the issue.
Thanks,
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>

Re: [PATCH 3/3] mfd: tps65910: fix wrong ack_base register

[Samuel Ortiz]

Hi Milo,

On Thu, Nov 29, 2012 at 06:42:12AM +0000, Kim, Milo wrote:
>  The interrupt status registers of TPS65910/1 should be cleared
>  when the associated interrupt event occurs.
>  This work is done in the regmap irq thread - using 'ack_base' register.
>  The ACK registers should be fixed as status register, not mask registers.
> 
>  This patch fixes the infinite interrupt event problem by clearing
>  interrupt status registers.
> 
>  Tested on the AM3517 Craneboard.
> 
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
> ---
>  drivers/mfd/tps65910.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied, thanks.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/