From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Dan Williams <djbw@fb.com>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"David Woodhouse" <dwmw2@infradead.org>,
"Håvard Skinnemoen" <hskinnemoen@gmail.com>,
"Ira Snyder" <iws@ovro.caltech.edu>,
"Koul, Vinod" <vinod.koul@intel.com>,
vipin.kumar@st.com, t.figa@samsung.com,
"kyungmin.park@samsung.com" <kyungmin.park@samsung.com>,
"Dave Jiang" <dave.jiang@gmail.com>
Subject: Re: [PATCH 00/20] DMA: DMA unmap fixes
Date: Fri, 30 Nov 2012 11:57:38 +0100 [thread overview]
Message-ID: <201211301157.38802.b.zolnierkie@samsung.com> (raw)
In-Reply-To: <CAA9_cmfkDkF7tEmVTfD_vxtMhoTwxfFPnxtOEPT_xwsNgT1=8g@mail.gmail.com>
On Wednesday 07 November 2012 21:40:57 Dan Williams wrote:
> On Mon, Nov 5, 2012 at 2:00 AM, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
> > Hi,
> >
> > Currently DMA subsystem does DMA mapping in the core code and DMA
> > unmapping is done by device drivers. This is counterintuitive,
> > causes code duplication and subtle errors (some drivers like PL330
> > one don't implement DMA unmapping code). The following patchset
> > modifies DMA subsystem to do DMA unmapping in the core code.
> > It results in simpler code, less code duplication (more than 400
> > LOC is gone) and fixes the issue with missing DMA unmapping code
> > in some drivers. Additionally many cases when DMA wasn't unmapped
> > on a failure are also fixed.
> >
> >
> > patches #1-3 add missing DMA unmap on failure to async_tx core
> > code (async_memcpy()), ioat and fsmc_nand drivers
> >
> > patch #4 fixes DMA flags used by carma-fpga driver
>
> Ack patches 1-4
[...]
> > patch #8 adds missing DMA unmap on failure to ioat3 driver
> >
> > patch #9 fixes build for async_memset.c
> >
> > patch #10 adds missing DMA unmap on failure to async tx core
> > code (async_memset())
>
> Ack patches 8-10
Thank you.
Could these patches be merged for 3.8 by either your's or Vinod's tree?
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung Poland R&D Center
prev parent reply other threads:[~2012-11-30 11:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 10:00 [PATCH 00/20] DMA: DMA unmap fixes Bartlomiej Zolnierkiewicz
2012-11-05 10:00 ` [PATCH 01/20] async_tx: add missing DMA unmap to async_memcpy() Bartlomiej Zolnierkiewicz
2012-11-05 10:00 ` [PATCH 02/20] ioat: add missing DMA unmap to ioat_dma_self_test() Bartlomiej Zolnierkiewicz
2012-11-05 10:00 ` [PATCH 03/20] mtd: fsmc_nand: add missing DMA unmap to dma_xfer() Bartlomiej Zolnierkiewicz
2012-11-05 10:00 ` [PATCH 04/20] carma-fpga: pass correct flags to ->device_prep_dma_memcpy() Bartlomiej Zolnierkiewicz
2012-11-05 10:00 ` [PATCH 05/20] dmatest: do DMA unmap for MEMCPY operations Bartlomiej Zolnierkiewicz
2012-11-05 10:00 ` [PATCH 06/20] DMA: do DMA unmap in core " Bartlomiej Zolnierkiewicz
2012-11-05 10:00 ` [PATCH 07/20] async_tx: " Bartlomiej Zolnierkiewicz
2012-11-05 10:00 ` [PATCH 08/20] ioat3: add missing DMA unmap to ioat_xor_val_self_test() Bartlomiej Zolnierkiewicz
2012-11-05 10:00 ` [PATCH 09/20] async_tx: fix build for async_memset Bartlomiej Zolnierkiewicz
2012-11-05 10:00 ` [PATCH 10/20] async_tx: add missing DMA unmap to async_memset() Bartlomiej Zolnierkiewicz
2012-11-05 10:00 ` [PATCH 11/20] async_tx: do DMA unmap in core for MEMSET operations Bartlomiej Zolnierkiewicz
2012-11-05 10:00 ` [PATCH 12/20] dmatest: do DMA unmap for XOR operations Bartlomiej Zolnierkiewicz
2012-11-05 10:00 ` [PATCH 13/20] async_tx: do DMA unmap in core " Bartlomiej Zolnierkiewicz
2012-11-07 20:56 ` Dan Williams
2012-11-19 9:52 ` Dan Williams
2012-11-05 10:00 ` [PATCH 14/20] async_tx: do DMA unmap in core for XOR_VAL operations Bartlomiej Zolnierkiewicz
2012-11-05 10:00 ` [PATCH 15/20] dmatest: do DMA unmap for PQ operations Bartlomiej Zolnierkiewicz
2012-11-05 10:00 ` [PATCH 16/20] async_tx: do DMA unmap in async_raid6_recov.c " Bartlomiej Zolnierkiewicz
2012-11-05 10:00 ` [PATCH 17/20] async_tx: do DMA unmap in core " Bartlomiej Zolnierkiewicz
2012-11-05 10:00 ` [PATCH 18/20] async_tx: do DMA unmap in core for PQ_VAL operations Bartlomiej Zolnierkiewicz
2012-11-05 10:00 ` [PATCH 19/20] DMA: remove DMA unmap from drivers Bartlomiej Zolnierkiewicz
2012-11-05 10:00 ` [PATCH 20/20] DMA: remove DMA unmap flags Bartlomiej Zolnierkiewicz
2012-11-05 19:34 ` [PATCH 00/20] DMA: DMA unmap fixes Ira W. Snyder
2012-11-06 10:12 ` Tomasz Figa
2012-11-07 20:40 ` Dan Williams
2012-11-30 10:57 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211301157.38802.b.zolnierkie@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=dave.jiang@gmail.com \
--cc=djbw@fb.com \
--cc=dwmw2@infradead.org \
--cc=hskinnemoen@gmail.com \
--cc=iws@ovro.caltech.edu \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=t.figa@samsung.com \
--cc=vinod.koul@intel.com \
--cc=vipin.kumar@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox