From: Samuel Ortiz <sameo@linux.intel.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: yongjun_wei@trendmicro.com.cn, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mfd: sta2x11-mfd: fix potential NULL pointer dereference in __sta2x11_mfd_mask()
Date: Mon, 3 Dec 2012 00:47:42 +0100 [thread overview]
Message-ID: <20121202234742.GZ3176@sortiz-mobl> (raw)
In-Reply-To: <CAPgLHd_0FZAtGnshNqD3RkGD9Qr+85vfxd2joSoc4U6Ef8JdKQ@mail.gmail.com>
Hi Wei,
On Sun, Dec 02, 2012 at 08:36:22AM -0500, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> The dereference to 'mfd' should be moved below the NULL test.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/mfd/sta2x11-mfd.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Patch applied, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2012-12-02 23:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-02 13:36 [PATCH -next] mfd: sta2x11-mfd: fix potential NULL pointer dereference in __sta2x11_mfd_mask() Wei Yongjun
2012-12-02 23:47 ` Samuel Ortiz [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-12-02 13:33 Wei Yongjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121202234742.GZ3176@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox