From: "Hans J. Koch" <hjk@hansjkoch.de>
To: "Hans J. Koch" <hjk@hansjkoch.de>,
Vitalii Demianets <vitas@nppfactor.kiev.ua>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] uio.c: Fix warning: 'ret' might be used uninitialized
Date: Mon, 3 Dec 2012 08:51:11 +0100 [thread overview]
Message-ID: <20121203075110.GC7723@local> (raw)
In-Reply-To: <20121201095831.GA18966@gmail.com>
On Sat, Dec 01, 2012 at 09:58:32AM +0000, Cong Ding wrote:
> If it is really necessary to save the 4 lines of codes, I would suggest to do
> in the following style. But you are more senior than me, so I may be wrong in
> this aspect.
"Seniority" (whatever you mean by that) has got nothing to do with it.
I'll accept any child's patch if it is good. Discussing code on LKML is
a purely technically thing, only if two patches are technically equivalent,
the maintainer's personal taste will decide. And if it makes you feel better:
My patches (and those of any other developer) are also sometimes rejected
because they are not to some other maintainer's taste.
Thanks,
Hans
next prev parent reply other threads:[~2012-12-03 7:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 11:48 [PATCH] uio.c: Fix warning: 'ret' might be used uninitialized Vitalii Demianets
2012-11-27 12:24 ` Vitalii Demianets
2012-11-27 22:43 ` Hans J. Koch
2012-11-28 8:58 ` Vitalii Demianets
2012-11-28 21:05 ` Hans J. Koch
2012-11-29 16:05 ` Tux9
2012-11-29 16:22 ` Vitalii Demianets
2012-11-29 16:33 ` Cong Ding
2012-11-29 16:36 ` Vitalii Demianets
2012-11-29 23:58 ` Hans J. Koch
2012-11-30 11:12 ` Tux9
2012-11-30 21:33 ` Hans J. Koch
2012-12-01 1:22 ` Cong Ding
2012-12-01 3:56 ` Hans J. Koch
2012-12-01 9:58 ` Cong Ding
2012-12-03 7:51 ` Hans J. Koch [this message]
2012-11-30 11:16 ` Vitalii Demianets
2012-11-30 21:39 ` Hans J. Koch
2012-11-30 23:43 ` Greg Kroah-Hartman
2012-12-03 7:41 ` [PATCH] stable: uio: " Hans J. Koch
2012-12-03 13:38 ` Ben Hutchings
2012-12-03 8:35 ` [PATCH] uio.c: " Vitalii Demianets
2012-12-03 8:53 ` Vitalii Demianets
2012-12-03 17:27 ` Hans J. Koch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203075110.GC7723@local \
--to=hjk@hansjkoch.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vitas@nppfactor.kiev.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).