From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Cong Ding <dinggnu@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Adam Buchbinder" <adam.buchbinder@gmail.com>,
"Jesper Juhl" <jj@chaosbits.net>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers:staging: fix compilation warning
Date: Mon, 3 Dec 2012 07:19:11 -0800 [thread overview]
Message-ID: <20121203151911.GA3359@kroah.com> (raw)
In-Reply-To: <1354530848-12516-1-git-send-email-dinggnu@gmail.com>
On Mon, Dec 03, 2012 at 10:34:08AM +0000, Cong Ding wrote:
> We do not allow old-style function definition. Always spell foo(void) if
> a function does not take any parameters.
>
> Signed-off-by: Cong Ding <dinggnu@gmail.com>
> ---
> drivers/staging/telephony/ixj.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
As Dan pointed out, you have to work against linux-next, otherwise you
waste time fixing things that might not even be in the tree anymore,
like this code.
sorry,
greg k-h
prev parent reply other threads:[~2012-12-03 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 10:34 [PATCH] drivers:staging: fix compilation warning Cong Ding
2012-12-03 10:56 ` Dan Carpenter
2012-12-03 11:04 ` Cong Ding
2012-12-03 15:19 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203151911.GA3359@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adam.buchbinder@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=dinggnu@gmail.com \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox