From: Andrew Morton <akpm@linux-foundation.org>
To: Josh Hunt <johunt@akamai.com>
Cc: jaxboe@fusionio.com, kay.sievers@vrfy.org, tj@kernel.org,
linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] block: Restore /proc/partitions to not display non-partitionable removable devices
Date: Mon, 3 Dec 2012 16:06:47 -0800 [thread overview]
Message-ID: <20121203160647.11ad34d8.akpm@linux-foundation.org> (raw)
In-Reply-To: <1353380209-23799-1-git-send-email-johunt@akamai.com>
On Mon, 19 Nov 2012 18:56:49 -0800
Josh Hunt <johunt@akamai.com> wrote:
> We found with newer kernels we started seeing the cdrom device showing
> up in /proc/partitions, but it was not there before. Looking into this I found
> that commit d27769ec... block: add GENHD_FL_NO_PART_SCAN introduces this change
> in behavior. It's not clear to me from the commit's changelog if this change was
> intentional or not. This comment still remains:
> /* Don't show non-partitionable removeable devices or empty devices */
> so I've decided to send a patch to restore the behavior of not printing
> unpartitionable removable devices.
d27769ec was merged in August 2011, so I after all this time, your fix
could be viewed as "changing existing behaviour".
So perhaps it would be best to leave things alone. Is there any
particular problem with the post-Aug, 2011 behaviour?
next prev parent reply other threads:[~2012-12-04 0:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 2:56 [PATCH] block: Restore /proc/partitions to not display non-partitionable removable devices Josh Hunt
2012-11-27 15:58 ` Josh Hunt
2012-12-04 0:06 ` Andrew Morton [this message]
2012-12-04 0:40 ` Josh Hunt
2012-12-04 0:54 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203160647.11ad34d8.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=jaxboe@fusionio.com \
--cc=johunt@akamai.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox