From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752475Ab2LDIvj (ORCPT ); Tue, 4 Dec 2012 03:51:39 -0500 Received: from mga01.intel.com ([192.55.52.88]:55209 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751388Ab2LDIvh (ORCPT ); Tue, 4 Dec 2012 03:51:37 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,213,1355126400"; d="scan'208";a="258666356" Date: Tue, 4 Dec 2012 08:53:59 +0000 From: Alan Cox To: Ilya Zykov Cc: Alan Cox , Xiaobing Tu , Jiri Slaby , Alek Du , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH] tty: Correct tty buffer flushing. Message-ID: <20121204085359.03894026@bob.linux.org.uk> In-Reply-To: <50B76D96.20809@ilyx.ru> References: <50B55A93.4090900@ilyx.ru> <50B6A652.9000107@ilyx.ru> <20121129135418.4237e7f8@pyramind.ukuu.org.uk> <50B76D96.20809@ilyx.ru> Organization: Intel X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.13; x86_64-redhat-linux-gnu) Organisation: Intel Corporation UK Ltd, registered no. 1134945 (England), Registered office Pipers Way, Swindon, SN3 1RJ Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Main idea here - we never flash last (struct tty_buffer) in the > active buffer. Only data for ldisc. (tty->buf.head->read = > tty->buf.head->commit). At that moment driver can collect(write) data > in buffer without conflict. This one I agree with (sorry it took a while to get to, I wanted to sit and think carefully about it as it is subtle and clever) Can you generate a single patch which reverts the unneeded locks and adds this instead. Add a Signed-off-by and send it to Greg to get it into 3.8/3.9 somewhere. Thanks Alan