From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Kevin Liu <keyuan.liu@gmail.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Liam Girdwood <lrg@ti.com>, Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH 3/3] mmc: sdhci: check voltage range only on regulators aware of voltage value
Date: Wed, 5 Dec 2012 10:48:25 +0900 [thread overview]
Message-ID: <20121205014823.GA28474@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CADz5_gLAWyD-3nYEV5HJad11wxEmxO867LkWOXDBn1_XmcOA_w@mail.gmail.com>
On Tue, Dec 04, 2012 at 10:50:03PM +0800, Kevin Liu wrote:
> 2012/12/4 Marek Szyprowski <m.szyprowski@samsung.com>:
> > + if (host->vmmc && regulator_get_voltage(host->vmmc) > 0) {
> > ret = regulator_is_supported_voltage(host->vmmc, 2700000,
> > 3600000);
> > if ((ret <= 0) || (!(caps[0] & SDHCI_CAN_VDD_330)))
> Good idea. But how about the regulator is disabled at this point? So I
> suggest to change to
> if (host->vmmc && regulator_get_voltage(host->vmmc) >= 0)
I'd not expect regulator_get_voltage() to return 0 for disabled
regulators, I'd expect it to return the voltage the regulator will have
when enabled.
next prev parent reply other threads:[~2012-12-05 1:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 14:01 [PATCH v2 0/3] Fix fixed regulators support Marek Szyprowski
2012-12-04 14:01 ` [PATCH 1/3] regulators: add regulator_can_change_voltage() function Marek Szyprowski
2012-12-06 6:18 ` Mark Brown
2012-12-04 14:01 ` [PATCH 2/3] mmc: use regulator_can_change_voltage() instead of regulator_count_voltages() hacks Marek Szyprowski
2013-02-01 14:39 ` Marek Szyprowski
2013-02-11 17:26 ` Chris Ball
2012-12-04 14:01 ` [PATCH 3/3] mmc: sdhci: check voltage range only on regulators aware of voltage value Marek Szyprowski
2012-12-04 14:50 ` Kevin Liu
2012-12-05 1:48 ` Mark Brown [this message]
2012-12-05 2:12 ` Kevin Liu
2013-02-01 14:40 ` Marek Szyprowski
2013-02-11 17:27 ` Chris Ball
2013-02-12 8:01 ` [PATCH 3/3 RESEND] " Marek Szyprowski
2013-02-12 22:10 ` Guennadi Liakhovetski
2013-02-13 7:33 ` Marek Szyprowski
2013-02-13 7:45 ` Guennadi Liakhovetski
2013-02-13 11:35 ` Mark Brown
2013-02-14 8:05 ` Marek Szyprowski
2013-02-14 11:03 ` Mark Brown
2013-02-14 11:08 ` Ulf Hansson
2013-02-20 9:34 ` Kevin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121205014823.GA28474@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=keyuan.liu@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lrg@ti.com \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).