From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 2/3] perf hists: Link hist entries before inserting to an output tree
Date: Wed, 5 Dec 2012 16:12:09 -0300 [thread overview]
Message-ID: <20121205191209.GE6629@ghostprotocols.net> (raw)
In-Reply-To: <20121205190646.GB1037@krava.brq.redhat.com>
Em Wed, Dec 05, 2012 at 08:06:46PM +0100, Jiri Olsa escreveu:
> On Wed, Dec 05, 2012 at 03:56:42PM +0900, Namhyung Kim wrote:
> > From: Namhyung Kim <namhyung.kim@lge.com>
> > @@ -481,6 +459,11 @@ static void hists__process(struct hists *old, struct hists *new)
> > else
> > hists__link(new, old);
> >
> > + hists__output_resort(new);
> > +
> > + if (show_displacement)
> > + hists__compute_position(new);
> > +
>
> Computing the position after hists__link screws up the position data,
> because we likely have new entries in.
>
> However, I wonder if anyone is actualy using displacement info..?
IIRC that was used long ago in the first version of 'perf diff', that
is not the default, probably we can just ditch it to simplify things,
can you check?
- Arnaldo
next prev parent reply other threads:[~2012-12-05 19:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 6:56 [PATCH v2 0/3] perf hists: Changes on hists__{match,link} Namhyung Kim
2012-12-05 6:56 ` [PATCH 1/3] perf hists: Exchange order of comparing items when collapsing hists Namhyung Kim
2012-12-05 6:56 ` [PATCH 2/3] perf hists: Link hist entries before inserting to an output tree Namhyung Kim
2012-12-05 19:06 ` Jiri Olsa
2012-12-05 19:12 ` Arnaldo Carvalho de Melo [this message]
2012-12-06 13:22 ` [PATCH] perf diff: Removing displacement output option Jiri Olsa
2012-12-06 13:28 ` Namhyung Kim
2013-01-24 18:56 ` [tip:perf/core] perf diff: Remove " tip-bot for Jiri Olsa
2012-12-05 19:15 ` [PATCH 2/3] perf hists: Link hist entries before inserting to an output tree Jiri Olsa
2012-12-06 1:07 ` Namhyung Kim
2012-12-05 6:56 ` [PATCH 3/3] perf diff: Use internal rb tree for compute resort Namhyung Kim
2012-12-05 12:20 ` [PATCH] perf test: Add a test case for hists__{match,link} Namhyung Kim
-- strict thread matches above, loose matches on Subject: below --
2012-12-04 4:44 [PATCH 0/3] perf hists: Changes on hists__{link,match} Namhyung Kim
2012-12-04 4:44 ` [PATCH 2/3] perf hists: Link hist entries before inserting to an output tree Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121205191209.GE6629@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).