From: Grant Likely <grant.likely@secretlab.ca>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>,
Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH v2 3/3] leds: leds-pwm: Add device tree bindings
Date: Thu, 06 Dec 2012 10:00:52 +0000 [thread overview]
Message-ID: <20121206100052.EC8293E0E22@localhost> (raw)
In-Reply-To: <1352731270-27534-4-git-send-email-peter.ujfalusi@ti.com>
On Mon, 12 Nov 2012 15:41:10 +0100, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> Support for device tree booted kernel.
> When the kernel is booted with DeviceTree blob we support one led per
> leds-pwm device to have cleaner integration with the PWM subsystem.
>
> For usage see:
> Documentation/devicetree/bindings/leds/leds-pwm.txt
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> .../devicetree/bindings/leds/leds-pwm.txt | 34 ++++++
> drivers/leds/leds-pwm.c | 125 +++++++++++++++------
> 2 files changed, 127 insertions(+), 32 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.txt
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.txt b/Documentation/devicetree/bindings/leds/leds-pwm.txt
> new file mode 100644
> index 0000000..9fe3040
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-pwm.txt
> @@ -0,0 +1,34 @@
> +LED connected to PWM
> +
> +Required properties:
> +- compatible : should be "pwm-leds".
> +- pwms : PWM property, please refer to:
> + Documentation/devicetree/bindings/pwm/pwm.txt
> +- pwm-names : (optional) Name to be used by the PWM subsystem for the PWM device
> +- label : (optional) The label for this LED. If omitted, the label is
> + taken from the node name (excluding the unit address).
> +- max-brightness : Maximum brightness possible for the LED
> +- linux,default-trigger : (optional) This parameter, if present, is a
> + string defining the trigger assigned to the LED. Current triggers are:
> + "backlight" - LED will act as a back-light, controlled by the framebuffer
> + system
> + "default-on" - LED will turn on, but see "default-state" below
> + "heartbeat" - LED "double" flashes at a load average based rate
> + "ide-disk" - LED indicates disk activity
> + "timer" - LED flashes at a fixed, configurable rate
The binding mostly looks good. However, it seems to be gratuitously
different from the gpio-leds binding and it duplicates property
definitions. Please match the gpio-leds behaviour with each led defined
as a sub node of the pwm-leds node.
Also, please reference the common properties in bindings/leds/common.txt
(This is a new file in linux-next. See how leds-gpio references it).
Otherwise the binding looks okay to me.
next prev parent reply other threads:[~2012-12-06 10:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 14:41 [PATCH v2 0/3] leds: leds-pwm: Device tree support Peter Ujfalusi
2012-11-12 14:41 ` [PATCH v2 1/3] leds: leds-pwm: Convert to use devm_get_pwm Peter Ujfalusi
2012-11-14 1:14 ` Bryan Wu
2012-11-14 7:13 ` Peter Ujfalusi
2012-12-03 14:13 ` Peter Ujfalusi
2012-12-03 18:32 ` Bryan Wu
2012-12-04 8:11 ` Peter Ujfalusi
2012-12-04 17:34 ` Bryan Wu
2012-12-05 15:36 ` Peter Ujfalusi
2012-11-12 14:41 ` [PATCH v2 2/3] leds: leds-pwm: Preparing the driver for device tree support Peter Ujfalusi
2012-11-12 14:41 ` [PATCH v2 3/3] leds: leds-pwm: Add device tree bindings Peter Ujfalusi
2012-12-06 10:00 ` Grant Likely [this message]
2012-12-06 12:36 ` Peter Ujfalusi
2012-12-07 13:34 ` Grant Likely
2012-12-07 14:04 ` Peter Ujfalusi
2012-12-10 22:37 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206100052.EC8293E0E22@localhost \
--to=grant.likely@secretlab.ca \
--cc=cooloney@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox