From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423137Ab2LFLNA (ORCPT ); Thu, 6 Dec 2012 06:13:00 -0500 Received: from mail-bk0-f46.google.com ([209.85.214.46]:50636 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423082Ab2LFLM6 (ORCPT ); Thu, 6 Dec 2012 06:12:58 -0500 Date: Thu, 6 Dec 2012 11:12:52 +0000 From: Lee Jones To: Viresh Kumar Cc: Grant Likely , Samuel Ortiz , rabin.vincent@stericsson.com, shiraz.hashim@st.com, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, spear-devel@list.st.com, linus.walleij@linaro.org, Vipul Kumar Samar Subject: Re: [PATCH V5 2/2] mfd: stmpe: Update DT support in stmpe driver Message-ID: <20121206111252.GR2718@gmail.com> References: <20121130154542.GG23648@gmail.com> <20121205224203.691153E0E22@localhost> <20121206095019.GN2718@gmail.com> <20121206101131.GP2718@gmail.com> <20121206103515.GQ2718@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 06 Dec 2012, Viresh Kumar wrote: > On 6 December 2012 16:05, Lee Jones wrote: > >> > Or you could not put unnecessary bindings into the Device Tree > >> > by putting two and two together and realise that using the table > >> > is the correct thing to do instead. This actually gives reason > >> > to you previous patch, but should probably be fixed-up into it > >> > so it has some proper meaning/purpose. ;) > >> > >> Couldn't understand this one :( > > > > Really? > > I tried again, but couldn't get it :( > > > Let's break it down - what do you need "stmpe,id" for? > > To distinguish two instances of of stmpe811 (for instance) on a board. > Names of stmpe sub-modules would contain .0, .1, if we have an id > passed to it. Passing -1 would create same names for both gpio blocks > which belonged to different stmpe811's. I thought we'd be over this? The 'ID' will be represented by the address of the chip i.e. stmpe1601@40, where '40' will be distinguishing factor? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog