From: Stanislav Kinsbursky <skinsbursky@parallels.com>
To: bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
devel@openvz.org
Subject: [PATCH 2/8] nfsd: per-net NFSd up flag introduced
Date: Thu, 06 Dec 2012 14:23:14 +0300 [thread overview]
Message-ID: <20121206112314.29559.48129.stgit@localhost.localdomain> (raw)
In-Reply-To: <20121206111903.29559.4853.stgit@localhost.localdomain>
This patch introduces introduces per-net "nfsd_net_up" boolean flag, which has
the same purpose as general "nfsd_up" flag - skip init or shutdown of per-net
resources in case of they are inited on shutted down respectively.
Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
---
fs/nfsd/netns.h | 2 ++
fs/nfsd/nfssvc.c | 12 ++++++++++++
2 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/fs/nfsd/netns.h b/fs/nfsd/netns.h
index bca789d..da8741b 100644
--- a/fs/nfsd/netns.h
+++ b/fs/nfsd/netns.h
@@ -92,6 +92,8 @@ struct nfsd_net {
time_t nfsd4_lease;
time_t nfsd4_grace;
+
+ bool nfsd_net_up;
};
extern int nfsd_net_id;
diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
index 038348b..6e17efd 100644
--- a/fs/nfsd/nfssvc.c
+++ b/fs/nfsd/nfssvc.c
@@ -21,6 +21,7 @@
#include "nfsd.h"
#include "cache.h"
#include "vfs.h"
+#include "netns.h"
#define NFSDDBG_FACILITY NFSDDBG_SVC
@@ -205,8 +206,12 @@ static bool nfsd_up = false;
static int nfsd_startup_net(struct net *net)
{
+ struct nfsd_net *nn = net_generic(net, nfsd_net_id);
int ret;
+ if (nn->nfsd_net_up)
+ return 0;
+
ret = nfsd_init_socks(net);
if (ret)
return ret;
@@ -217,6 +222,7 @@ static int nfsd_startup_net(struct net *net)
if (ret)
goto out_lockd;
+ nn->nfsd_net_up = true;
return 0;
out_lockd:
@@ -257,8 +263,14 @@ out_racache:
static void nfsd_shutdown_net(struct net *net)
{
+ struct nfsd_net *nn = net_generic(net, nfsd_net_id);
+
+ if (!nn->nfsd_net_up)
+ return;
+
nfs4_state_shutdown_net(net);
lockd_down(net);
+ nn->nfsd_net_up = false;
}
static void nfsd_shutdown(struct net *net)
next prev parent reply other threads:[~2012-12-06 11:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 11:22 [PATCH 0/8] nfsd: make service created per net Stanislav Kinsbursky
2012-12-06 11:23 ` [PATCH 1/8] nfsd: move per-net startup code to separated function Stanislav Kinsbursky
2012-12-06 11:23 ` Stanislav Kinsbursky [this message]
2012-12-06 11:23 ` [PATCH 3/8] nfsd: make NFSd service boot time per-net Stanislav Kinsbursky
2012-12-06 11:23 ` [PATCH 4/8] nfsd: make NFSd service structure allocated per net Stanislav Kinsbursky
2012-12-06 11:23 ` [PATCH 5/8] nfsd: introduce helpers for generic resources init and shutdown Stanislav Kinsbursky
2012-12-06 11:23 ` [PATCH 6/8] nfsd: simplify NFSv4 state " Stanislav Kinsbursky
2012-12-06 11:23 ` [PATCH 7/8] nfsd: replace boolean nfsd_up flag by users counter Stanislav Kinsbursky
2012-12-06 11:23 ` [PATCH 8/8] nfsd: simplify service shutdown Stanislav Kinsbursky
2012-12-10 20:18 ` [PATCH 0/8] nfsd: make service created per net J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206112314.29559.48129.stgit@localhost.localdomain \
--to=skinsbursky@parallels.com \
--cc=bfields@fieldses.org \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).