From: Greg KH <greg@kroah.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, stable <stable@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [v3.0 stable version][PATCH 1/2] ring-buffer: Fix NULL pointer if rb_set_head_page() fails
Date: Thu, 6 Dec 2012 12:13:26 -0800 [thread overview]
Message-ID: <20121206201326.GA10874@kroah.com> (raw)
In-Reply-To: <1354292203.6276.159.camel@gandalf.local.home>
On Fri, Nov 30, 2012 at 11:16:43AM -0500, Steven Rostedt wrote:
> The function rb_set_head_page() searches the list of ring buffer
> pages for a the page that has the HEAD page flag set. If it does
> not find it, it will do a WARN_ON(), disable the ring buffer and
> return NULL, as this should never happen.
>
> But if this bug happens to happen, not all callers of this function
> can handle a NULL pointer being returned from it. That needs to be
> fixed.
>
> Cc: stable@vger.kernel.org # 3.0+
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> ---
> kernel/trace/ring_buffer.c | 9 +++++++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
I don't understand why you sent these to stable@ right now, I don't see
them in Linus's tree, so why are they needed here?
Care to resend them when they hit Linus's tree?
thanks,
greg k-h
next prev parent reply other threads:[~2012-12-06 20:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 16:12 [PATCH 0/2] [GIT PULL][v3.7] ring-buffer: Bug fixes Steven Rostedt
2012-11-30 16:12 ` [PATCH 1/2] ring-buffer: Fix NULL pointer if rb_set_head_page() fails Steven Rostedt
2012-11-30 16:16 ` [v3.0 stable version][PATCH " Steven Rostedt
2012-12-06 20:13 ` Greg KH [this message]
2012-12-06 21:41 ` Steven Rostedt
2012-12-07 0:36 ` Greg KH
2012-11-30 16:18 ` [v3.2-v3.4 " Steven Rostedt
2012-12-27 15:55 ` Ben Hutchings
2012-11-30 16:20 ` [PATCH " Steven Rostedt
2012-11-30 16:12 ` [PATCH 2/2] ring-buffer: Fix race between integrity check and readers Steven Rostedt
2012-11-30 16:21 ` Steven Rostedt
2012-12-08 14:43 ` [PATCH 0/2] [GIT PULL][v3.7] ring-buffer: Bug fixes Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2012-12-12 18:43 [v3.0 stable version][PATCH 1/2] ring-buffer: Fix NULL pointer if rb_set_head_page() fails Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206201326.GA10874@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox