* [PATCH] spi: Fix comparison of different integer types
@ 2012-12-06 23:35 Grant Likely
2012-12-07 3:48 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Grant Likely @ 2012-12-06 23:35 UTC (permalink / raw)
To: linux-kernel, spi-devel-general; +Cc: Grant Likely, Mark Brown
Fix problem discovered with sparse:
+ drivers/spi/spi.c:1554:37: sparse: incompatible types in comparison expression (different signedness)
drivers/spi/spi.c: In function 'spi_write_then_read':
drivers/spi/spi.c:1554:23: warning: comparison of distinct pointer types lacks a cast [enabled by default]
The change to SPI_BUFSIZ was introduced in commit b3a223ee2, "spi:
Remove SPI_BUFSIZ restriction on spi_write_then_read()"
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
drivers/spi/spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 22c71e2..b370d292 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -1551,7 +1551,7 @@ int spi_write_then_read(struct spi_device *spi,
* using the pre-allocated buffer or the transfer is too large.
*/
if ((n_tx + n_rx) > SPI_BUFSIZ || !mutex_trylock(&lock)) {
- local_buf = kmalloc(max(SPI_BUFSIZ, n_tx + n_rx), GFP_KERNEL);
+ local_buf = kmalloc(max((unsigned)SPI_BUFSIZ, n_tx + n_rx), GFP_KERNEL);
if (!local_buf)
return -ENOMEM;
} else {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] spi: Fix comparison of different integer types
2012-12-06 23:35 [PATCH] spi: Fix comparison of different integer types Grant Likely
@ 2012-12-07 3:48 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-12-07 3:48 UTC (permalink / raw)
To: Grant Likely; +Cc: linux-kernel, spi-devel-general
On Thu, Dec 06, 2012 at 11:35:47PM +0000, Grant Likely wrote:
> Fix problem discovered with sparse:
> + drivers/spi/spi.c:1554:37: sparse: incompatible types in comparison expression (different signedness)
> drivers/spi/spi.c: In function 'spi_write_then_read':
> drivers/spi/spi.c:1554:23: warning: comparison of distinct pointer types lacks a cast [enabled by default]
>
> The change to SPI_BUFSIZ was introduced in commit b3a223ee2, "spi:
> Remove SPI_BUFSIZ restriction on spi_write_then_read()"
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-07 3:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-06 23:35 [PATCH] spi: Fix comparison of different integer types Grant Likely
2012-12-07 3:48 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).