linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: tglx@linutronix.de, peterz@infradead.org,
	paulmck@linux.vnet.ibm.com, rusty@rustcorp.com.au,
	mingo@kernel.org, akpm@linux-foundation.org, namhyung@kernel.org,
	vincent.guittot@linaro.org, tj@kernel.org, oleg@redhat.com
Cc: sbw@mit.edu, amit.kucheria@linaro.org, rostedt@goodmis.org,
	rjw@sisk.pl, srivatsa.bhat@linux.vnet.ibm.com,
	wangyun@linux.vnet.ibm.com, xiaoguangrong@linux.vnet.ibm.com,
	nikunj@linux.vnet.ibm.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [RFC PATCH v3 7/9] yield_to(), cpu-hotplug: Prevent offlining of other CPUs properly
Date: Fri, 07 Dec 2012 23:09:53 +0530	[thread overview]
Message-ID: <20121207173950.27305.39499.stgit@srivatsabhat.in.ibm.com> (raw)
In-Reply-To: <20121207173702.27305.1486.stgit@srivatsabhat.in.ibm.com>

Once stop_machine() is gone from the CPU offline path, we won't be able to
depend on local_irq_save() to prevent CPUs from going offline from under us.

Use the get/put_online_cpus_atomic() APIs to prevent CPUs from going offline,
while invoking from atomic context.

Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
---

 kernel/sched/core.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index cff7656..4b982bf 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4312,6 +4312,7 @@ bool __sched yield_to(struct task_struct *p, bool preempt)
 	unsigned long flags;
 	bool yielded = 0;
 
+	get_online_cpus_atomic();
 	local_irq_save(flags);
 	rq = this_rq();
 
@@ -4339,13 +4340,14 @@ again:
 		 * Make p's CPU reschedule; pick_next_entity takes care of
 		 * fairness.
 		 */
-		if (preempt && rq != p_rq)
+		if (preempt && rq != p_rq && cpu_online(task_cpu(p)))
 			resched_task(p_rq->curr);
 	}
 
 out:
 	double_rq_unlock(rq, p_rq);
 	local_irq_restore(flags);
+	put_online_cpus_atomic();
 
 	if (yielded)
 		schedule();


  parent reply	other threads:[~2012-12-07 17:41 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-07 17:37 [RFC PATCH v3 0/9] CPU hotplug: stop_machine()-free CPU hotplug Srivatsa S. Bhat
2012-12-07 17:38 ` [RFC PATCH v3 1/9] CPU hotplug: Provide APIs to prevent CPU offline from atomic context Srivatsa S. Bhat
2012-12-07 17:57   ` Tejun Heo
2012-12-07 18:16     ` Tejun Heo
2012-12-07 18:33       ` Srivatsa S. Bhat
2012-12-07 18:24     ` Srivatsa S. Bhat
2012-12-07 18:31       ` Tejun Heo
2012-12-07 18:38         ` Srivatsa S. Bhat
2012-12-09 19:14   ` Oleg Nesterov
2012-12-09 19:50     ` Srivatsa S. Bhat
2012-12-09 20:22       ` Oleg Nesterov
2012-12-10  4:28         ` Srivatsa S. Bhat
2012-12-10 17:24           ` Oleg Nesterov
2012-12-11 13:13             ` Srivatsa S. Bhat
2012-12-11 13:47               ` Tejun Heo
2012-12-11 14:02                 ` Srivatsa S. Bhat
2012-12-11 14:07                   ` Tejun Heo
2012-12-11 16:28                     ` Srivatsa S. Bhat
2012-12-09 21:13       ` Oleg Nesterov
2012-12-10  5:01         ` Srivatsa S. Bhat
2012-12-10 17:28           ` Oleg Nesterov
2012-12-11 13:05             ` Srivatsa S. Bhat
2012-12-09 20:57   ` Oleg Nesterov
2012-12-10  5:19     ` Srivatsa S. Bhat
2012-12-10 18:15       ` Oleg Nesterov
2012-12-11 13:04         ` Srivatsa S. Bhat
2012-12-07 17:38 ` [RFC PATCH v3 2/9] CPU hotplug: Convert preprocessor macros to static inline functions Srivatsa S. Bhat
2012-12-07 17:38 ` [RFC PATCH v3 3/9] smp, cpu hotplug: Fix smp_call_function_*() to prevent CPU offline properly Srivatsa S. Bhat
2012-12-07 17:39 ` [RFC PATCH v3 4/9] smp, cpu hotplug: Fix on_each_cpu_*() " Srivatsa S. Bhat
2012-12-07 17:39 ` [RFC PATCH v3 5/9] sched, cpu hotplug: Use stable online cpus in try_to_wake_up() & select_task_rq() Srivatsa S. Bhat
2012-12-07 17:39 ` [RFC PATCH v3 6/9] kick_process(), cpu-hotplug: Prevent offlining of target CPU properly Srivatsa S. Bhat
2012-12-07 17:39 ` Srivatsa S. Bhat [this message]
2012-12-09 19:48   ` [RFC PATCH v3 7/9] yield_to(), cpu-hotplug: Prevent offlining of other CPUs properly Oleg Nesterov
2012-12-09 19:57     ` Srivatsa S. Bhat
2012-12-09 20:40       ` Oleg Nesterov
2012-12-10  4:04         ` Srivatsa S. Bhat
2012-12-07 17:40 ` [RFC PATCH v3 8/9] kvm, vmx: Add atomic synchronization with CPU Hotplug Srivatsa S. Bhat
2012-12-07 17:40 ` [RFC PATCH v3 9/9] cpu: No more __stop_machine() in _cpu_down() Srivatsa S. Bhat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121207173950.27305.39499.stgit@srivatsabhat.in.ibm.com \
    --to=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=amit.kucheria@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=nikunj@linux.vnet.ibm.com \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rjw@sisk.pl \
    --cc=rostedt@goodmis.org \
    --cc=rusty@rustcorp.com.au \
    --cc=sbw@mit.edu \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=wangyun@linux.vnet.ibm.com \
    --cc=xiaoguangrong@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).