* [PATCH] staging: echo: remove unused variable
@ 2012-12-04 1:21 Cong Ding
2012-12-09 15:19 ` Cong Ding
0 siblings, 1 reply; 3+ messages in thread
From: Cong Ding @ 2012-12-04 1:21 UTC (permalink / raw)
To: Steve Underwood, David Rowe, Greg Kroah-Hartman, Jesper Juhl,
devel, linux-kernel
Cc: Cong Ding
the variable j isn't used in the loop
Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
drivers/staging/echo/echo.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/echo/echo.c b/drivers/staging/echo/echo.c
index ca87ce9..14dfd91 100644
--- a/drivers/staging/echo/echo.c
+++ b/drivers/staging/echo/echo.c
@@ -119,7 +119,6 @@
static inline void lms_adapt_bg(struct oslec_state *ec, int clean, int shift)
{
int i;
- int j;
int offset1;
int offset2;
int factor;
@@ -142,7 +141,7 @@ static inline void lms_adapt_bg(struct oslec_state *ec, int clean, int shift)
/* asm("st:"); */
n = ec->taps;
- for (i = 0, j = offset2; i < n; i++, j++) {
+ for (i = 0; i < n; i++) {
exp = *phist++ * factor;
ec->fir_taps16[1][i] += (int16_t) ((exp + (1 << 14)) >> 15);
}
--
1.7.4.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: echo: remove unused variable
2012-12-04 1:21 [PATCH] staging: echo: remove unused variable Cong Ding
@ 2012-12-09 15:19 ` Cong Ding
2012-12-10 9:50 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Cong Ding @ 2012-12-09 15:19 UTC (permalink / raw)
To: Steve Underwood, David Rowe, Greg Kroah-Hartman, Jesper Juhl,
devel, linux-kernel
ping!
- cong
On Tue, Dec 04, 2012 at 01:21:44AM +0000, Cong Ding wrote:
> the variable j isn't used in the loop
>
> Signed-off-by: Cong Ding <dinggnu@gmail.com>
> ---
> drivers/staging/echo/echo.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/echo/echo.c b/drivers/staging/echo/echo.c
> index ca87ce9..14dfd91 100644
> --- a/drivers/staging/echo/echo.c
> +++ b/drivers/staging/echo/echo.c
> @@ -119,7 +119,6 @@
> static inline void lms_adapt_bg(struct oslec_state *ec, int clean, int shift)
> {
> int i;
> - int j;
> int offset1;
> int offset2;
> int factor;
> @@ -142,7 +141,7 @@ static inline void lms_adapt_bg(struct oslec_state *ec, int clean, int shift)
>
> /* asm("st:"); */
> n = ec->taps;
> - for (i = 0, j = offset2; i < n; i++, j++) {
> + for (i = 0; i < n; i++) {
> exp = *phist++ * factor;
> ec->fir_taps16[1][i] += (int16_t) ((exp + (1 << 14)) >> 15);
> }
> --
> 1.7.4.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: echo: remove unused variable
2012-12-09 15:19 ` Cong Ding
@ 2012-12-10 9:50 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2012-12-10 9:50 UTC (permalink / raw)
To: Cong Ding
Cc: Steve Underwood, David Rowe, Greg Kroah-Hartman, Jesper Juhl,
devel, linux-kernel
On Sun, Dec 09, 2012 at 03:19:09PM +0000, Cong Ding wrote:
> ping!
>
Calm your buns. :P If you don't hear back from anyone, it probably
means that your patch is going to be merged. But you've caught us
at a bad moment because the 3.8 merge window is about to open. It
could take over a month before someone looks at this. Wait for two
weeks after the 3.8-rc1 kernel has been released and then check back
on this.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-10 9:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-04 1:21 [PATCH] staging: echo: remove unused variable Cong Ding
2012-12-09 15:19 ` Cong Ding
2012-12-10 9:50 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).