From: Dan Carpenter <dan.carpenter@oracle.com>
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com,
gregkh@linuxfoundation.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, yongjun_wei@trendmicro.com.cn,
marcos.souza.org@gmail.com, Larry.Finger@lwfinger.net
Subject: Re: [PATCH] staging: rtl8712: avoid a useless call to memset().
Date: Mon, 10 Dec 2012 11:55:16 +0300 [thread overview]
Message-ID: <20121210085516.GO6568@mwanda> (raw)
In-Reply-To: <50C3DBF6.2080103@gmail.com>
On Sun, Dec 09, 2012 at 01:31:50AM +0100, Cyril Roelandt wrote:
> On 12/05/2012 08:11 AM, Dan Carpenter wrote:
> >On Wed, Dec 05, 2012 at 02:22:02AM +0100, Cyril Roelandt wrote:
> >>In r8711_wx_get_wap(), make sure we do not call memcpy() on a memory area that
> >>has just been zeroed by a call to memset().
> >>
> >
> >I look at it like the original code is fine. Your version is also
> >fine but is it worth the churn? Also the curly braces are not
> >needed.
> >
>
> Sorry about the braces.
>
> I just thought the code would be easier to understand this way, but
> it's probably OK to leave it as it currently is too.
>
Ah. I'd buy that. I like readability fixes. The indenting is also
messed up and confusing. It should be:
if (check_fwstate(pmlmepriv, _FW_LINKED | WIFI_ADHOC_MASTER_STATE |
WIFI_AP_STATE))
memcpy(wrqu->ap_addr.sa_data, pcur_bss->MacAddress, ETH_ALEN);
else
memset(wrqu->ap_addr.sa_data, 0, ETH_ALEN);
regards,
dan carpenter
next prev parent reply other threads:[~2012-12-10 8:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 1:22 [PATCH] staging: rtl8712: avoid a useless call to memset() Cyril Roelandt
2012-12-05 4:07 ` Larry Finger
2012-12-05 7:11 ` Dan Carpenter
2012-12-09 0:31 ` Cyril Roelandt
2012-12-10 8:55 ` Dan Carpenter [this message]
2012-12-05 8:12 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210085516.GO6568@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
--cc=tipecaml@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).