From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com,
Przemo Firszt <przemo@firszt.eu>,
linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net
Subject: Re: [PATCH 5/5] rtl8712: replace leading spaces with tab
Date: Mon, 10 Dec 2012 15:21:03 +0300 [thread overview]
Message-ID: <20121210122103.GT6568@mwanda> (raw)
In-Reply-To: <1355140186.26815.6.camel@joe-AO722>
On Mon, Dec 10, 2012 at 03:49:46AM -0800, Joe Perches wrote:
> On Mon, 2012-12-10 at 12:46 +0300, Dan Carpenter wrote:
> > On Sun, Dec 09, 2012 at 10:15:10AM +0000, Przemo Firszt wrote:
> > > Replace leading spaces with tab
> []
> > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> []
> > > static int r871x_set_wpa_ie(struct _adapter *padapter, char *pie,
> > > - unsigned short ielen)
> > > + unsigned short ielen)
> >
> > The original version is better because it lines up correctly.
> >
> > Checkpatch doesn't complain for me so I'm not sure what the story is
> > here.
>
> Parenthesis alignment isn't described in CodingStyle.
> It's maintainer's preference. Whether or not it should
> be is a different question.
>
> checkpatch parenthesis alignment of arguments checks are
> emitted only when adding --strict to the command line.
>
Even with --strict checkpatch.pl is fine with the original code.
I don't know any subsystems where the new version would be prefered
over the original version.
regards,
dan carpenter
next prev parent reply other threads:[~2012-12-10 12:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-09 10:15 [PATCH 1/5] rtl8712: code clean up Przemo Firszt
2012-12-09 10:15 ` [PATCH 2/5] rtl8712: remove unused macros from rtl8712/wifi.h Przemo Firszt
2012-12-09 10:15 ` [PATCH 3/5] rtl8712: replace printk with better solutions Przemo Firszt
2012-12-09 11:47 ` Joe Perches
2012-12-09 10:15 ` [PATCH 4/5] rtl8712: replace min with min_t Przemo Firszt
2012-12-10 9:41 ` Dan Carpenter
2012-12-10 22:21 ` Przemo Firszt
2012-12-10 22:49 ` Dan Carpenter
2012-12-10 23:20 ` Przemo Firszt
2012-12-09 10:15 ` [PATCH 5/5] rtl8712: replace leading spaces with tab Przemo Firszt
2012-12-10 9:46 ` Dan Carpenter
2012-12-10 11:49 ` Joe Perches
2012-12-10 12:21 ` Dan Carpenter [this message]
2012-12-10 13:47 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210122103.GT6568@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=przemo@firszt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).