From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753075Ab2LJOKH (ORCPT ); Mon, 10 Dec 2012 09:10:07 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:53156 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751437Ab2LJOKG (ORCPT ); Mon, 10 Dec 2012 09:10:06 -0500 Date: Mon, 10 Dec 2012 23:10:01 +0900 From: Mark Brown To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de, linus.walleij@stericsson.com, ulf.hansson@linaro.org Subject: Re: [PATCH 02/12] regulator: gpio-regulator: Only read GPIO [dis|en]able pin if not always-on Message-ID: <20121210141000.GC6103@opensource.wolfsonmicro.com> References: <1355129761-8088-1-git-send-email-lee.jones@linaro.org> <1355129761-8088-3-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1355129761-8088-3-git-send-email-lee.jones@linaro.org> X-Cookie: You dialed 5483. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 10, 2012 at 08:55:51AM +0000, Lee Jones wrote: > If a regulator is specified as always-on, then it can't have an > enable/disable pin, as it can't be turned off. Sometimes always on gets set for regulators which do have a physical control wired up - the control might exist for use in suspend mode for example. Is the ability to specify an enable pin causing a practical problem for systems? If it is we should fix that.