From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753413Ab2LJONL (ORCPT ); Mon, 10 Dec 2012 09:13:11 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:59256 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752808Ab2LJONI (ORCPT ); Mon, 10 Dec 2012 09:13:08 -0500 Date: Mon, 10 Dec 2012 23:13:03 +0900 From: Mark Brown To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de, linus.walleij@stericsson.com, ulf.hansson@linaro.org Subject: Re: [PATCH 04/12] regulator: gpio-regulator: gpio_set_value should use cansleep Message-ID: <20121210141302.GE6103@opensource.wolfsonmicro.com> References: <1355129761-8088-1-git-send-email-lee.jones@linaro.org> <1355129761-8088-5-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1355129761-8088-5-git-send-email-lee.jones@linaro.org> X-Cookie: You dialed 5483. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 10, 2012 at 08:55:53AM +0000, Lee Jones wrote: > If it's possible for gpio_set_value to sleep, we should be using > the *_cansleep call instead. This patch fixes multiple warnings > from gpiolib. Applied, thanks.