From: Grant Likely <grant.likely@secretlab.ca>
To: Linus Walleij <linus.walleij@linaro.org>, Axel Lin <axel.lin@ingics.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
Thomas Abraham <thomas.abraham@linaro.org>,
Tomasz Figa <t.figa@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: samsung: Add terminating entry for exynos_pinctrl_ids
Date: Mon, 10 Dec 2012 22:10:45 +0000 [thread overview]
Message-ID: <20121210221045.4EA803E0D9C@localhost> (raw)
In-Reply-To: <CACRpkdY=yoYi71MLC=7iktFMTTQWmk4iLwrKqOnuuJEz43K74g@mail.gmail.com>
On Mon, 10 Dec 2012 11:13:06 +0100, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, Dec 10, 2012 at 2:35 AM, Axel Lin <axel.lin@ingics.com> wrote:
>
> > The of_device_id table is supposed to be zero-terminated.
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > ---
> > drivers/gpio/gpio-samsung.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> > index 01f7fe9..9e251be 100644
> > --- a/drivers/gpio/gpio-samsung.c
> > +++ b/drivers/gpio/gpio-samsung.c
> > @@ -3026,6 +3026,7 @@ static __init int samsung_gpiolib_init(void)
> > static const struct of_device_id exynos_pinctrl_ids[] = {
> > { .compatible = "samsung,pinctrl-exynos4210", },
> > { .compatible = "samsung,pinctrl-exynos4x12", },
> > + { }
>
> Wasn't somebody complaining that this was unnecessary recently?
>
> Ohwell, I'll let the Samsung people comment first...
And this doesn't apply on my gpio/next branch. I assume it applies
somewhere else so I'll ignore for now. :-)
Acked-by: Grant Likely <grant.likely@secretlab.ca>
g.
prev parent reply other threads:[~2012-12-10 22:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 1:35 [PATCH] gpio: samsung: Add terminating entry for exynos_pinctrl_ids Axel Lin
2012-12-10 10:13 ` Linus Walleij
2012-12-10 22:10 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210221045.4EA803E0D9C@localhost \
--to=grant.likely@secretlab.ca \
--cc=axel.lin@ingics.com \
--cc=kgene.kim@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox