From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752637Ab2LKIp1 (ORCPT ); Tue, 11 Dec 2012 03:45:27 -0500 Received: from mail-we0-f174.google.com ([74.125.82.174]:60156 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752546Ab2LKIpZ (ORCPT ); Tue, 11 Dec 2012 03:45:25 -0500 From: Grant Likely Subject: Re: [PATCH RFC 03/13] OF: define of_*_cmp() macros also if CONFIG_OF isn't set To: Sylwester Nawrocki , g.liakhovetski@gmx.de, linux-media@vger.kernel.org Cc: rob.herring@calxeda.com, thomas.abraham@linaro.org, t.figa@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org In-Reply-To: <1355168499-5847-4-git-send-email-s.nawrocki@samsung.com> References: <1355168499-5847-1-git-send-email-s.nawrocki@samsung.com> <1355168499-5847-4-git-send-email-s.nawrocki@samsung.com> Date: Tue, 11 Dec 2012 08:45:09 +0000 Message-Id: <20121211084509.2DEE83E076D@localhost> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Dec 2012 20:41:29 +0100, Sylwester Nawrocki wrote: > From: Guennadi Liakhovetski > > of_*_cmp() macros do not depend on any OF functions and can be defined also > if CONFIG_OF isn't set. Also include linux/string.h, required by those > macros. Patch looks fine, but I'd like to know the situation where you found this problem. Again, anything calling these of_ helpers is probably CONFIG_OF specific code. I've resisted doing a blanket add of these helpers outside of CONFIG_OF exactly because it helps identify CONFIG_OF code that should be compiled out when CONFIG_OF=n g. > > Signed-off-by: Guennadi Liakhovetski > --- > include/linux/of.h | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/include/linux/of.h b/include/linux/of.h > index 9ba8cf1..38d4b1a 100644 > --- a/include/linux/of.h > +++ b/include/linux/of.h > @@ -85,6 +85,14 @@ static inline struct device_node *of_node_get(struct device_node *node) > static inline void of_node_put(struct device_node *node) { } > #endif /* !CONFIG_OF_DYNAMIC */ > > +/* Default string compare functions, Allow arch asm/prom.h to override */ > +#if !defined(of_compat_cmp) > +#include > +#define of_compat_cmp(s1, s2, l) strcasecmp((s1), (s2)) > +#define of_prop_cmp(s1, s2) strcmp((s1), (s2)) > +#define of_node_cmp(s1, s2) strcasecmp((s1), (s2)) > +#endif > + > #ifdef CONFIG_OF > > /* Pointer for first entry in chain of all nodes. */ > @@ -143,13 +151,6 @@ static inline unsigned long of_read_ulong(const __be32 *cell, int size) > #define OF_ROOT_NODE_SIZE_CELLS_DEFAULT 1 > #endif > > -/* Default string compare functions, Allow arch asm/prom.h to override */ > -#if !defined(of_compat_cmp) > -#define of_compat_cmp(s1, s2, l) strcasecmp((s1), (s2)) > -#define of_prop_cmp(s1, s2) strcmp((s1), (s2)) > -#define of_node_cmp(s1, s2) strcasecmp((s1), (s2)) > -#endif > - > /* flag descriptions */ > #define OF_DYNAMIC 1 /* node and properties were allocated via kmalloc */ > #define OF_DETACHED 2 /* node has been detached from the device tree */ > -- > 1.7.9.5 > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd.