public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: fangxiaozhi 00110321 <fangxiaozhi@huawei.com>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<zihan@huawei.com>, <Lin.Lei@huawei.com>, <greg@kroah.com>,
	<neil.yi@huawei.com>, <wangyuhua@huawei.com>,
	<huqiao36@huawei.com>
Subject: Re: [PATCH 1/1]linux-usb: optimize to match the Huawei USB storage devices and support new switch command
Date: Wed, 12 Dec 2012 10:51:51 +0000	[thread overview]
Message-ID: <20121212105151.09635a76@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <fe8c905bb12.b12fe8c905b@huawei.com>

On Wed, 12 Dec 2012 18:20:33 +0800
fangxiaozhi 00110321 <fangxiaozhi@huawei.com> wrote:

> From: fangxiaozhi <huananhu@huawei.com>
> 
> 1. To optimize the match rules for the Huawei USB storage devices. Avoid to load USB storage driver for modem interface with Huawei devices.
> 2. Add to support new switch command for new Huawei USB dongles.

This prevents people getting access to the storage device if they want.
It also means you need to change kernel not simply a user space file to
add support for different new identifiers.

So it seems a large step backwards to me.

Why not just teach udev the new switch command then it'll work as a udev
update on all sorts of existing kernels as well as being the kind of
small safe change you can get into the entprise distributions ?

Alan

  parent reply	other threads:[~2012-12-12 10:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-12 10:20 [PATCH 1/1]linux-usb: optimize to match the Huawei USB storage devices and support new switch command fangxiaozhi 00110321
2012-12-12 10:28 ` Felipe Balbi
2012-12-12 10:51 ` Alan Cox [this message]
     [not found]   ` <910F9D9E13B84F4C8FA771DC9BDE99F326FBFB54@szxeml546-mbs.china.huawei.com>
2012-12-14  9:31     ` Alan Cox
2012-12-14  9:33       ` Oliver Neukum
2012-12-14 10:28         ` Fangxiaozhi (Franko)
2012-12-14 10:42           ` Oliver Neukum
2012-12-14 10:02       ` 答复: " Fangxiaozhi (Franko)
  -- strict thread matches above, loose matches on Subject: below --
2013-01-05  2:57 [PATCH 1/1]linux-usb:optimize " fangxiaozhi 00110321
2013-01-08 10:57 ` Sebastian Andrzej Siewior
2013-01-08 11:58   ` Oliver Neukum
2013-01-23  6:07 fangxiaozhi 00110321

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121212105151.09635a76@pyramind.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=Lin.Lei@huawei.com \
    --cc=fangxiaozhi@huawei.com \
    --cc=greg@kroah.com \
    --cc=huqiao36@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=neil.yi@huawei.com \
    --cc=wangyuhua@huawei.com \
    --cc=zihan@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox