From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Linus Walleij <linus.walleij@linaro.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drivers/pinctrl/pinctrl-at91.c: convert kfree to devm_kfree
Date: Wed, 12 Dec 2012 12:56:24 +0100 [thread overview]
Message-ID: <20121212115624.GI4398@game.jcrosoft.org> (raw)
In-Reply-To: <1355223525-19165-1-git-send-email-Julia.Lawall@lip6.fr>
On 11:58 Tue 11 Dec , Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The function at91_dt_node_to_map is ultimately called by the function
> pinctrl_get, which is an exported function. Since it is possible that this
> function is not called from within a probe function, for safety, the kfree
> is converted to a devm_kfree, to both free the data and remove it from the
> device in a failure situation.
>
> A newline is added in the call to devm_kfree to avoid exceeding the 80
> character limit.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/pinctrl/pinctrl-at91.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index c5e7571..0da8a5f 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -255,7 +255,8 @@ static int at91_dt_node_to_map(struct pinctrl_dev *pctldev,
> }
>
> map_num += grp->npins;
> - new_map = devm_kzalloc(pctldev->dev, sizeof(*new_map) * map_num, GFP_KERNEL);
> + new_map = devm_kzalloc(pctldev->dev, sizeof(*new_map) * map_num,
> + GFP_KERNEL);
not related please drop
> if (!new_map)
> return -ENOMEM;
>
> @@ -265,7 +266,7 @@ static int at91_dt_node_to_map(struct pinctrl_dev *pctldev,
> /* create mux map */
> parent = of_get_parent(np);
> if (!parent) {
> - kfree(new_map);
> + devm_kfree(pctldev->dev, new_map);
ok
> return -EINVAL;
> }
> new_map[0].type = PIN_MAP_TYPE_MUX_GROUP;
>
Best Regards,
J.
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2012-12-12 11:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 10:58 [PATCH] drivers/pinctrl/pinctrl-at91.c: convert kfree to devm_kfree Julia Lawall
2012-12-11 13:00 ` Sergei Shtylyov
2012-12-11 13:08 ` Julia Lawall
2012-12-11 18:26 ` Sergei Shtylyov
2012-12-12 11:56 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-12-12 14:22 ` Julia Lawall
2012-12-12 17:01 ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-14 15:46 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121212115624.GI4398@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox