From: Andrew Morton <akpm@linux-foundation.org>
To: Ashish Jangam <ashish.jangam@kpitcummins.com>
Cc: <linux-kernel@vger.kernel.org>, <sameo@linux.intel.com>,
<p_gortmaker@yahoo.com>, <dchen@diasemi.com>,
<rtc-linux@googlegroups.com>,
Alessandro Zummo <a.zummo@towertech.it>,
shubhro <omaplinuxkernel@gmail.com>
Subject: Re: [Patch v3 3/7] rtc: DA9055 RTC driver
Date: Wed, 12 Dec 2012 13:11:08 -0800 [thread overview]
Message-ID: <20121212131108.1e158ae2.akpm@linux-foundation.org> (raw)
In-Reply-To: <1355118149.4272.1.camel@dhruva>
On Mon, 10 Dec 2012 11:12:29 +0530
Ashish Jangam <ashish.jangam@kpitcummins.com> wrote:
> On Wed, 2012-11-28 at 14:54 +0530, Ashish Jangam wrote:
> > On Tue, 2012-11-27 at 14:23 -0800, Andrew Morton wrote:
> > > On Fri, 23 Nov 2012 15:41:03 +0530
> > > Ashish Jangam <ashish.jangam@kpitcummins.com> wrote:
> > >
> > > > On Tue, 2012-10-23 at 15:33 +0530, Ashish Jangam wrote:
> > > > > Does this patch looks good?
> > > > > On Thu, 2012-10-11 at 16:10 +0530, Ashish Jangam wrote:
> > > > > > This is the RTC patch for the DA9055 PMIC. This patch has got dependency on
> > > > > > the DA9055 MFD core.
> > > > > >
> > > > > > This patch is functionally tested on Samsung SMDKV6410.
> > >
> > > "shubhro <omaplinuxkernel@gmail.com>" made a comment, but it was ignored:
> > >
> > > : On Thu, 11 Oct 2012 16:53:34 +0530
> > > : shubhro <omaplinuxkernel@gmail.com> wrote:
> > > :
> > > : > On Thursday 11 October 2012 04:10 PM, Ashish Jangam wrote:
> > > : > > +#define da9055_rtc_freeze NULL
> > > : > > +#endif
> > > : > > +
> > > : > > +static const struct dev_pm_ops da9055_rtc_pm_ops = {
> > > : > > + .suspend = da9055_rtc_suspend,
> > > : > > + .resume = da9055_rtc_resume,
> > > : > > +
> > > : > > + .freeze = da9055_rtc_freeze,
> > > : > > + .thaw = da9055_rtc_resume,
> > > : > > + .restore = da9055_rtc_resume,
> > > : > > +
> > > : > > + .poweroff = da9055_rtc_suspend,
> > > : > > +};
> > > : > You may want to use simple dev pm ops
> > To support generic PM ops these additional ops were supported.
> Are there any further comments on this patch.
Is the patch usable against current mainline? "This patch has got
dependency on the DA9055 MFD core". What is the status of that?
If the patch is ready to go then please refresh it, retest and resend?
next prev parent reply other threads:[~2012-12-12 21:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 10:40 [Patch v3 3/7] RTC: DA9055 RTC driver Ashish Jangam
2012-10-11 11:23 ` shubhro
2012-10-23 10:03 ` Ashish Jangam
2012-11-23 10:11 ` [Patch v3 3/7] rtc: " Ashish Jangam
2012-11-23 11:09 ` Venu Byravarasu
2012-11-23 12:27 ` Ashish Jangam
2012-11-27 22:23 ` Andrew Morton
2012-11-28 9:24 ` Ashish Jangam
2012-12-10 5:42 ` Ashish Jangam
2012-12-12 21:11 ` Andrew Morton [this message]
2012-12-13 5:51 ` Ashish Jangam
2012-12-13 13:04 ` Ashish Jangam
2012-12-13 21:39 ` Andrew Morton
2012-11-28 9:24 ` Ashish Jangam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121212131108.1e158ae2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.zummo@towertech.it \
--cc=ashish.jangam@kpitcummins.com \
--cc=dchen@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=omaplinuxkernel@gmail.com \
--cc=p_gortmaker@yahoo.com \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox