From: Dan Carpenter <dan.carpenter@oracle.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
jasowang@redhat.com
Subject: Re: [PATCH 1/1] Drivers: hv: balloon: Fix a memory leak
Date: Thu, 13 Dec 2012 12:37:40 +0300 [thread overview]
Message-ID: <20121213093740.GW6568@mwanda> (raw)
In-Reply-To: <1355252837-9827-1-git-send-email-kys@microsoft.com>
On Tue, Dec 11, 2012 at 11:07:17AM -0800, K. Y. Srinivasan wrote:
> -probe_error1:
> +probe_error2:
> kthread_stop(dm_device.thread);
>
> -probe_error0:
> +probe_error1:
> vmbus_close(dev->channel);
> +probe_error0:
> + kfree(send_buffer);
If you used labels that describe what the code does instead of
GW-BASIC labels then you wouldn't need to rename them.
err_stop_thread:
kthread_stop(dm_device.thread);
err_close_vmbus:
vmbus_close(dev->channel);
err_free_send_buf:
kfree(send_buffer);
regards,
dan carpenter
next prev parent reply other threads:[~2012-12-13 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 19:07 [PATCH 1/1] Drivers: hv: balloon: Fix a memory leak K. Y. Srinivasan
2012-12-13 5:21 ` Jason Wang
2012-12-13 9:37 ` Dan Carpenter [this message]
2012-12-13 15:29 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121213093740.GW6568@mwanda \
--to=dan.carpenter@oracle.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox