From: Wang YanQing <udknight@gmail.com>
To: joerg.roedel@amd.com
Cc: alex.williamson@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH]iommu: make return value consistence
Date: Fri, 14 Dec 2012 00:55:57 +0800 [thread overview]
Message-ID: <20121213165557.GB10948@udknight> (raw)
if we don't define CONFIG_IOMMU_API the
dummy functions alway return -ENODEV
or -EINVAL except three function, so convert
them to the same behavior to make consistence
Signed-off-by: Wang YanQing <udknight@gmail.com>
---
include/linux/iommu.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index f4a49a6..16e84f6 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -210,7 +210,7 @@ static inline bool iommu_present(struct bus_type *bus)
static inline struct iommu_domain *iommu_domain_alloc(struct bus_type *bus)
{
- return NULL;
+ return ERR_PTR(-ENODEV);
}
static inline void iommu_domain_free(struct iommu_domain *domain)
@@ -275,7 +275,7 @@ static inline struct iommu_group *iommu_group_alloc(void)
static inline void *iommu_group_get_iommudata(struct iommu_group *group)
{
- return NULL;
+ return ERR_PTR(-EINVAL);
}
static inline void iommu_group_set_iommudata(struct iommu_group *group,
@@ -309,7 +309,7 @@ static inline int iommu_group_for_each_dev(struct iommu_group *group,
static inline struct iommu_group *iommu_group_get(struct device *dev)
{
- return NULL;
+ return ERR_PTR(-ENODEV);
}
static inline void iommu_group_put(struct iommu_group *group)
--
1.7.11.1.116.g8228a23
next reply other threads:[~2012-12-13 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 16:55 Wang YanQing [this message]
2012-12-13 17:10 ` [PATCH]iommu: make return value consistence Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121213165557.GB10948@udknight \
--to=udknight@gmail.com \
--cc=alex.williamson@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox