From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756255Ab2LMRlV (ORCPT ); Thu, 13 Dec 2012 12:41:21 -0500 Received: from mho-04-ewr.mailhop.org ([204.13.248.74]:47135 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753384Ab2LMRlT (ORCPT ); Thu, 13 Dec 2012 12:41:19 -0500 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.131.214.131 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19kpSZTxgleQDYCPD0SgsyE Date: Thu, 13 Dec 2012 09:41:11 -0800 From: Tony Lindgren To: NeilBrown Cc: Jon Hunter , Thierry Reding , Grant Erickson , linux-omap@vger.kernel.org, lkml Subject: Re: [PATCH] OMAP: add pwm driver using dmtimers. Message-ID: <20121213174110.GE4989@atomide.com> References: <20121212192430.50cea126@notabene.brown> <50C8ABFC.3080309@ti.com> <20121213140635.4eda5858@notabene.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121213140635.4eda5858@notabene.brown> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * NeilBrown [121212 19:09]: > On Wed, 12 Dec 2012 10:08:28 -0600 Jon Hunter wrote: > > On 12/12/2012 02:24 AM, NeilBrown wrote: > > > + > > > + /* Request the OMAP dual-mode timer that will be bound to and > > > + * associated with this generic PWM. > > > + */ > > > + > > > + omap->dm_timer = omap_dm_timer_request_specific(timer); > > > > I would recommend that you use omap_dm_timer_request_by_cap() (new for > > v3.8 so you should be able to use once v3.8-rc1 is out) here to request > > a timer that supports the PWM output. The above function will not be > > supported when booting with device-tree. > > I wasn't planning on rushing into working on 3.8-rcX so I'd rather not do > this now. > Would you object to the patch being submitted with the current call, then an > update when I do move on to 3.8? > > However.... I may be misunderstanding something, but I want a timer to drive > a particular output pin - GPIO-57. And I thought that it could only be > driver by GPT11. So I need to explicitly request number 11 don't I? Yes I believe it needs to tied to a specific GPT instance to have access to the pin. We should not export omap_dm_timer_request_specific(), that information should become from platform_data and device tree. Regards, Tony