From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753122Ab2LNIWB (ORCPT ); Fri, 14 Dec 2012 03:22:01 -0500 Received: from londo.lunn.ch ([80.238.139.98]:45656 "EHLO londo.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750986Ab2LNIWA (ORCPT ); Fri, 14 Dec 2012 03:22:00 -0500 Date: Fri, 14 Dec 2012 09:21:50 +0100 From: Andrew Lunn To: Dave Jones , Linux Kernel Mailing List , Jamie Lentin , Andrew Lunn , Simon Baatz , Jason Cooper Subject: Re: power: Add simple poweroff-gpio driver Message-ID: <20121214082150.GA7717@lunn.ch> References: <20121213202157.8106C66071E@gitolite.kernel.org> <20121213205159.GA21825@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121213205159.GA21825@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 13, 2012 at 03:51:59PM -0500, Dave Jones wrote: > On Thu, Dec 13, 2012 at 08:21:57PM +0000, Linux Kernel wrote: > > Gitweb: http://git.kernel.org/linus/;a=commit;h=96ff0f5c7efd4a2205c48a76a6a1fcd2731e6128 > > Commit: 96ff0f5c7efd4a2205c48a76a6a1fcd2731e6128 > > Parent: f4a00139b7cbeff538e616a21f6b57249a9d3ed8 > > Author: Jamie Lentin > > AuthorDate: Sat Nov 17 09:51:04 2012 +0100 > > Committer: Jason Cooper > > CommitDate: Sat Nov 24 02:56:38 2012 +0000 > > > > power: Add simple poweroff-gpio driver > > > > Given appropriate devicetree bindings, this driver registers a > > pm_power_off function to set a GPIO line high/low to power down > > your board. > > Given this seems to be dependant on device-tree, shouldn't there be > some 'depends on' in the kconfig to prevent this showing up on architectures > that don't implement it ? > > > +menuconfig POWER_RESET > > + bool "Board level reset or power off" > > + help > > + Provides a number of drivers which either reset a complete board > > + or shut it down, by manipulating the main power supply on the board. > > + > > + Say Y here to enable board reset and power off > > + > > +config POWER_RESET_GPIO > > + bool "GPIO power-off driver" > > + depends on OF_GPIO && POWER_RESET Hi Dave Don't these depends on here do what you want? > > + help > > + This driver supports turning off your board via a GPIO line. > > + If your board needs a GPIO high/low to power down, say Y and > > + create a binding in your devicetree. > > If not, upon seeing this, I suspect many users will ask "how do I know if I need this?" > given there's no mention of the sort of hardware this is useful on. Its a generic driver. I know its useful on various Marvell kirkwood and orion5x devices. I've also heard it useful on some Tegra boards. Are you asking i list these boards? Thanks Andrew