public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: suravee.suthikulpanit@amd.com
Cc: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com,
	acme@ghostprotocols.net, tglx@linutronix.de, hpa@zytor.com,
	rric@kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org,
	jacob.shin@amd.com
Subject: Re: [PATCH 1/1] Change IBS PMU to use perf_hw_context
Date: Sun, 16 Dec 2012 10:04:10 +0100	[thread overview]
Message-ID: <20121216090410.GC21690@gmail.com> (raw)
In-Reply-To: <1355518662-32071-1-git-send-email-suravee.suthikulpanit@amd.com>


* suravee.suthikulpanit@amd.com <suravee.suthikulpanit@amd.com> wrote:

> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> 
> Currently, the AMD IBS PMU initialize pmu.task_ctx_nr to 
> perf_invalid_context which only allows IBS to be running only 
> in system-wide mode (e.g. perf record -a). IBS hardware is 
> available in each core and should be per-context.  This patch 
> modifies the task_ctx_nr to use the perf_hw_context (default) 
> instead.

I'm wondering how extensively was it tested/verified that it's 
safe to enable IBS in per context mode as well, and that the 
profiling results are precise and accurate?

We never used the IBS hardware in this fashion before, so some 
extra care is prudent - and traces of that extra care should be 
visible in the changelog as well.

Thanks,

	Ingo

  reply	other threads:[~2012-12-16  9:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-14 20:57 [PATCH 1/1] Change IBS PMU to use perf_hw_context suravee.suthikulpanit
2012-12-16  9:04 ` Ingo Molnar [this message]
2012-12-17  9:44   ` Robert Richter
2012-12-18 22:54     ` Suravee Suthikulpanit
2013-01-16 22:19       ` Suravee Suthikulpanit
2013-06-18 16:03         ` Suravee Suthikulanit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121216090410.GC21690@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=hpa@zytor.com \
    --cc=jacob.shin@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=rric@kernel.org \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox