From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Arvind R <arvino55@gmail.com>
Cc: linux-edac@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-next@vger.kernel.org
Subject: Re: [PATCH 3.7.0 3/9] i82975x_edac.c: cleanup debug code
Date: Mon, 17 Dec 2012 12:45:11 -0200 [thread overview]
Message-ID: <20121217124511.66825216@redhat.com> (raw)
In-Reply-To: <CAA_L+UNa-C0XvzMbXMf9GchtfacfwJMYt2uuXkWVntWPWANLsA@mail.gmail.com>
Em Sun, 16 Dec 2012 02:10:39 +0530
Arvind R <arvino55@gmail.com> escreveu:
> Subject: [PATCH 3.7.0 3/9] i82975x_edac.c: cleanup debug code
>
> modify debug levels to sane levels. Also move random debug code
> into CONFIG_EDAC_DEBUG sections.
> Signed-off-by: Arvind R. <arvino55@gmail.com>
> ---
> i82975x_edac.c | 171 +++++++++++++++++++++++-------------------
> 1 file changed, 97 insertions(+), 74 deletions(-)
>
> --- a/drivers/edac/i82975x_edac.c 2012-12-15 20:18:24 +0530
> +++ b/drivers/edac/i82975x_edac.c 2012-12-15 20:17:58 +0530
...
> @@ -551,11 +583,11 @@ static int i82975x_probe1(struct pci_dev
> layers[1].is_virt_csrow = false;
> mci = edac_mc_alloc(0, ARRAY_SIZE(layers), layers, sizeof(*pvt));
> if (!mci) {
> + edac_dbg(0, "MC%d failed mc_alloc\n", dev_idx);
> rc = -ENOMEM;
> goto fail1;
Please remove the two last lines. There's no reason why it a driver
should bail out just because debug is enabled.
Cheers,
Mauro
next prev parent reply other threads:[~2012-12-17 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-15 20:40 [PATCH 3.7.0 3/9] i82975x_edac.c: cleanup debug code Arvind R
2012-12-17 14:45 ` Mauro Carvalho Chehab [this message]
2012-12-17 17:08 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121217124511.66825216@redhat.com \
--to=mchehab@redhat.com \
--cc=arvino55@gmail.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox