From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753235Ab2LQOpg (ORCPT ); Mon, 17 Dec 2012 09:45:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34636 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752626Ab2LQOpe (ORCPT ); Mon, 17 Dec 2012 09:45:34 -0500 Date: Mon, 17 Dec 2012 12:45:11 -0200 From: Mauro Carvalho Chehab To: Arvind R Cc: linux-edac@vger.kernel.org, LKML , linux-next@vger.kernel.org Subject: Re: [PATCH 3.7.0 3/9] i82975x_edac.c: cleanup debug code Message-ID: <20121217124511.66825216@redhat.com> In-Reply-To: References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sun, 16 Dec 2012 02:10:39 +0530 Arvind R escreveu: > Subject: [PATCH 3.7.0 3/9] i82975x_edac.c: cleanup debug code > > modify debug levels to sane levels. Also move random debug code > into CONFIG_EDAC_DEBUG sections. > Signed-off-by: Arvind R. > --- > i82975x_edac.c | 171 +++++++++++++++++++++++------------------- > 1 file changed, 97 insertions(+), 74 deletions(-) > > --- a/drivers/edac/i82975x_edac.c 2012-12-15 20:18:24 +0530 > +++ b/drivers/edac/i82975x_edac.c 2012-12-15 20:17:58 +0530 ... > @@ -551,11 +583,11 @@ static int i82975x_probe1(struct pci_dev > layers[1].is_virt_csrow = false; > mci = edac_mc_alloc(0, ARRAY_SIZE(layers), layers, sizeof(*pvt)); > if (!mci) { > + edac_dbg(0, "MC%d failed mc_alloc\n", dev_idx); > rc = -ENOMEM; > goto fail1; Please remove the two last lines. There's no reason why it a driver should bail out just because debug is enabled. Cheers, Mauro