[PATCH] kconfig:lxdialog: remove duplicate code

[PATCH] kconfig:lxdialog: remove duplicate code

[Wang YanQing]

dialog.h has two line the same below:
extern char dialog_input_result[];
This patch remove one of them.

Signed-off-by: Wang YanQing <udknight@gmail.com>
---
 scripts/kconfig/lxdialog/dialog.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/scripts/kconfig/lxdialog/dialog.h b/scripts/kconfig/lxdialog/dialog.h
index ee17a52..307022a 100644
--- a/scripts/kconfig/lxdialog/dialog.h
+++ b/scripts/kconfig/lxdialog/dialog.h
@@ -221,7 +221,6 @@ int dialog_menu(const char *title, const char *prompt,
 		const void *selected, int *s_scroll);
 int dialog_checklist(const char *title, const char *prompt, int height,
 		     int width, int list_height);
-extern char dialog_input_result[];
 int dialog_inputbox(const char *title, const char *prompt, int height,
 		    int width, const char *init);
 
-- 
1.7.11.1.116.g8228a23

Re: [PATCH] kconfig:lxdialog: remove duplicate code

[Yann E. MORIN]

Wang, All,

On Monday 17 December 2012 Wang YanQing wrote:
> dialog.h has two line the same below:
> extern char dialog_input_result[];
> This patch remove one of them.
> 
> Signed-off-by: Wang YanQing <udknight@gmail.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

> ---
>  scripts/kconfig/lxdialog/dialog.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/scripts/kconfig/lxdialog/dialog.h b/scripts/kconfig/lxdialog/dialog.h
> index ee17a52..307022a 100644
> --- a/scripts/kconfig/lxdialog/dialog.h
> +++ b/scripts/kconfig/lxdialog/dialog.h
> @@ -221,7 +221,6 @@ int dialog_menu(const char *title, const char *prompt,
>  		const void *selected, int *s_scroll);
>  int dialog_checklist(const char *title, const char *prompt, int height,
>  		     int width, int list_height);
> -extern char dialog_input_result[];
>  int dialog_inputbox(const char *title, const char *prompt, int height,
>  		    int width, const char *init);
>  
> -- 
> 1.7.11.1.116.g8228a23
> 
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Re: [PATCH] kconfig:lxdialog: remove duplicate code

[Wang YanQing]

On Mon, Dec 17, 2012 at 07:19:07PM +0100, Yann E. MORIN wrote:
> Wang, All,
> 
> On Monday 17 December 2012 Wang YanQing wrote:
> > dialog.h has two line the same below:
> > extern char dialog_input_result[];
> > This patch remove one of them.
> > 
> > Signed-off-by: Wang YanQing <udknight@gmail.com>
> 
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Michal, All.

Hi Michal, could you consider pick up this obvious right
patch, and consider others' three patch I sented one week
ago? I just don't want delay them to 2013, and they can get
more test when they appear in next tree.
https://patchwork.kernel.org/patch/1887361/
https://patchwork.kernel.org/patch/1894341/
https://patchwork.kernel.org/patch/1887441/

Happy christmas!

Thanks.

Re: [PATCH] kconfig:lxdialog: remove duplicate code

[Yann E. MORIN]

Wang, All,

On Monday 24 December 2012 Wang YanQing wrote:
> On Mon, Dec 17, 2012 at 07:19:07PM +0100, Yann E. MORIN wrote:
> > Wang, All,
> > 
> > On Monday 17 December 2012 Wang YanQing wrote:
> > > dialog.h has two line the same below:
> > > extern char dialog_input_result[];
> > > This patch remove one of them.
> > > 
> > > Signed-off-by: Wang YanQing <udknight@gmail.com>
> > 
> > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Michal, All.
> 
> Hi Michal, could you consider pick up this obvious right
> patch,

This code-duplication-removal patch could qualify for post-rc1.

> and consider others' three patch I sented one week
> ago? I just don't want delay them to 2013, and they can get
> more test when they appear in next tree.
> https://patchwork.kernel.org/patch/1887361/
> https://patchwork.kernel.org/patch/1894341/
> https://patchwork.kernel.org/patch/1887441/

It's too late for those: the merge window is closed, and they did not even
went into Michal's tree, so they definitely do not qualify for post-rc1.
We'll have to wait until the next merge window for inclusion.

Michal probably got caught by this shorter-than-usual merge window, and
missed the deadline. :-/

Wang, I've queued them here, and will push them again to Michal, after
the holidays season is over.

Merry Chrtistmas, and a Happy New Year to all! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Re: [PATCH] kconfig:lxdialog: remove duplicate code

[Yann E. MORIN]

Wang, All,

On Tuesday 25 December 2012 Yann E. MORIN wrote:
> On Monday 24 December 2012 Wang YanQing wrote:
[--SNIP--]
> > and consider others' three patch I sented one week
> > ago? I just don't want delay them to 2013, and they can get
> > more test when they appear in next tree.
> > https://patchwork.kernel.org/patch/1887361/
> > https://patchwork.kernel.org/patch/1894341/
> > https://patchwork.kernel.org/patch/1887441/
[--SNIP--]
> Wang, I've queued them here, and will push them again to Michal, after
> the holidays season is over.

I've started gathering kconfig-related patches suitable for post-3.8 there:
    git://gitorious.org/linux-kconfig/linux-kconfig.git yem-kconfig-for-next

They are browseable there:
    https://www.gitorious.org/linux-kconfig/linux-kconfig/commits/yem-kconfig-for-next

I'll send a proper pull-request to Michal in a litle while.

Note: the autoritative tree for kconfig is Michal's. I'm only doing this
gathering of patches in an attempt to not forget any, and to make Michal's
life easier, if he finds it usefull to pull from there.

Branches in that tree are based off Michal's branches, and so will be
rebased accordingly.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'