From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753625Ab2LQVUa (ORCPT ); Mon, 17 Dec 2012 16:20:30 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:63441 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544Ab2LQVU3 (ORCPT ); Mon, 17 Dec 2012 16:20:29 -0500 Date: Mon, 17 Dec 2012 13:20:23 -0800 From: Tejun Heo To: Vivek Goyal Cc: lizefan@huawei.com, axboe@kernel.dk, containers@lists.linux-foundation.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, ctalbott@google.com, rni@google.com Subject: Re: [PATCH 06/12] cfq-iosched: implement cfq_group->nr_active and ->level_weight Message-ID: <20121217212023.GE1844@htj.dyndns.org> References: <1355524885-22719-1-git-send-email-tj@kernel.org> <1355524885-22719-7-git-send-email-tj@kernel.org> <20121217204609.GH7235@redhat.com> <20121217211517.GC1844@htj.dyndns.org> <20121217211843.GA13691@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121217211843.GA13691@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 17, 2012 at 04:18:43PM -0500, Vivek Goyal wrote: > > > I think confusion happens because we are overloading the definition of > > > cfqg. It is competing with its siblings at the same time it is competing > > > against its child groups (on behalf of its children tasks). > > > > While I agree that part is a bit tricky, I can't think of a much > > better way to describe it. Any better ideas? > > Can we call it cfqg->children_weight insted of cfqg->level_weight. Hmmm... yeah, why not? I'll rename it. Thanks. -- tejun