public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Juergen Beisert <jbe@pengutronix.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Strange results of DIV_ROUND_CLOSEST
Date: Tue, 18 Dec 2012 09:16:20 -0800	[thread overview]
Message-ID: <20121218171620.GA19972@roeck-us.net> (raw)
In-Reply-To: <201212181603.42094.jbe@pengutronix.de>

On Tue, Dec 18, 2012 at 04:03:41PM +0100, Juergen Beisert wrote:
> Hi list,
> 
> commit 263a523d18bca306016d75f5c8d5c57c37fe52fb changes the code of 
> DIV_ROUND_CLOSEST in include/linux/kernel.h to fix a compile time warning.
> 
> But now feeding in a zero into this macro results into 4198403. Tested with 
> gcc 4.4.3 and 4.7.2, on arch x86 and ARM.
> 
> I can reproduce this behaviour, when my ADC delivers a '0' value in the driver 
> drivers/hwmon/s3c-hwmon.c in function s3c_hwmon_ch_show() with a current 
> 3.7.1 kernel. The value is correct again, when the ADC delivers at least 
> a '1'.
> 
> Any ideas how to fix it correctly?
> 
Odd one. I ran the macro through a large number of values and divisors as well
as various optimization options, with different compilers, and always get
correct results.

What are your compile options, and what are the channel multiplier and dividers
set to ?

Thanks,
Guenter

  reply	other threads:[~2012-12-18 17:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-18 15:03 Strange results of DIV_ROUND_CLOSEST Juergen Beisert
2012-12-18 17:16 ` Guenter Roeck [this message]
2012-12-18 21:04   ` Juergen Beisert
2012-12-18 22:59     ` Guenter Roeck
2012-12-19  1:45     ` Guenter Roeck
2012-12-19  7:32       ` Juergen Beisert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121218171620.GA19972@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jbe@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox