From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755443Ab2LRSdd (ORCPT ); Tue, 18 Dec 2012 13:33:33 -0500 Received: from mail.skyhub.de ([78.46.96.112]:45279 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751577Ab2LRSdb (ORCPT ); Tue, 18 Dec 2012 13:33:31 -0500 Date: Tue, 18 Dec 2012 19:33:30 +0100 From: Borislav Petkov To: Joe Perches Cc: Jacob Shin , Doug Thompson , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] MCE, AMD: MCE decoding support for AMD Family 16h Message-ID: <20121218183330.GH31255@liondog.tnic> Mail-Followup-To: Borislav Petkov , Joe Perches , Jacob Shin , Doug Thompson , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org References: <1355773188-5241-1-git-send-email-jacob.shin@amd.com> <1355773188-5241-2-git-send-email-jacob.shin@amd.com> <20121218171915.GE31255@liondog.tnic> <1355855069.30366.14.camel@joe-AO722> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1355855069.30366.14.camel@joe-AO722> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 18, 2012 at 10:24:29AM -0800, Joe Perches wrote: > or without all the unnecessary parens and using char: > > pr_cont("%cBUFF parity error\n", xec == 4 ? 'I' : 'O'); Char is fine, the parens make this more readable when you look at it again after a couple of months :-). Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --