From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: "Fangxiaozhi (Franko)" <fangxiaozhi@huawei.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Xueguiying (Zihan)" <zihan.xue@huawei.com>,
"Linlei (Lei Lin)" <lei.lin@huawei.com>,
"greg@kroah.com" <greg@kroah.com>,
"Yili (Neil)" <neil.yi@huawei.com>,
"Wangyuhua (Roger, Credit)" <wangyuhua@huawei.com>,
Huqiao <huqiao36@huawei.com>, "balbi@ti.com" <balbi@ti.com>
Subject: Re: [PATCH 2/2]linux-usb:optimize to match the Huawei USB storage devices and support new switch command
Date: Wed, 19 Dec 2012 09:34:30 +0100 [thread overview]
Message-ID: <20121219083430.GB3400@breakpoint.cc> (raw)
In-Reply-To: <910F9D9E13B84F4C8FA771DC9BDE99F326FCB006@szxeml546-mbs.china.huawei.com>
On Wed, Dec 19, 2012 at 03:13:32AM +0000, Fangxiaozhi (Franko) wrote:
> By the way, I found the kernel is updated to 3.7.1 today. So I have to update my patch based on 3.7.1, and resubmit it?
> Right?
You should rebase your patch on top of Greg's usb-next branch of his usb tree.
http://git.kernel.org/?p=linux/kernel/git/gregkh/usb.git;a=shortlog;h=refs/heads/usb-next
but I guess that there are hardly any changes in that area. The last change in
drivers/usb/storage/initializers.* is yours "USB: usb-storage fails to attach
to Huawei Datacard cdrom device".
If you call ./scripts/get_maintainer.pl on your patch you should learn that
you miss
|Matthew Dharm <mdharm-usb@one-eyed-alien.net>
|usb-storage@lists.one-eyed-alien.net
> > And shouldn't you read something from the us->recv_bulk_pipe after
> > that?
> Well, because our device will re-connect to switch the ports if it receives the command.
> So it is not necessary to read the response of the command.
Hmm. I guess this for Matthew / Greg to decide, I don't insist on anything.
Maybe a comment would be nice because now it looks, atleast to me, that
something is missing.
Sebastian
next prev parent reply other threads:[~2012-12-19 8:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 2:42 [PATCH 1/2]linux-usb:Define a new macro for USB storage match rules fangxiaozhi 00110321
2012-12-18 2:44 ` [PATCH 2/2]linux-usb:optimize to match the Huawei USB storage devices and support new switch command fangxiaozhi 00110321
2012-12-18 14:10 ` Sebastian Andrzej Siewior
2012-12-19 3:13 ` Fangxiaozhi (Franko)
2012-12-19 8:34 ` Sebastian Andrzej Siewior [this message]
2012-12-19 15:40 ` Matthew Dharm
2013-01-04 7:30 ` Fangxiaozhi (Franko)
-- strict thread matches above, loose matches on Subject: below --
2013-01-11 9:57 fangxiaozhi 00110321
2013-01-12 0:22 ` Greg KH
2013-01-14 2:29 ` Fangxiaozhi (Franko)
2013-01-13 22:05 ` Sebastian Andrzej Siewior
2013-01-25 2:46 fangxiaozhi 00110321
2013-01-27 18:48 ` Sebastian Andrzej Siewior
2013-02-04 7:16 fangxiaozhi 00110321
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219083430.GB3400@breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=balbi@ti.com \
--cc=fangxiaozhi@huawei.com \
--cc=greg@kroah.com \
--cc=huqiao36@huawei.com \
--cc=lei.lin@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.yi@huawei.com \
--cc=wangyuhua@huawei.com \
--cc=zihan.xue@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).