From: Grant Likely <grant.likely@secretlab.ca>
To: Linus Walleij <linus.walleij@linaro.org>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: linux-kernel@vger.kernel.org,
Jerome Oufella <jerome.oufella@savoirfairelinux.com>
Subject: Re: [PATCH v2] gpio: add TS-5500 DIO blocks support
Date: Wed, 19 Dec 2012 17:16:00 +0000 [thread overview]
Message-ID: <20121219171600.7B0EF3E0C5A@localhost> (raw)
In-Reply-To: <CACRpkdbjWz99SEV1gZKiNhiCS2k_CT+oznorNDpw=hvyF49Gkg@mail.gmail.com>
On Mon, 10 Dec 2012 10:55:04 +0100, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Sat, Dec 8, 2012 at 3:36 AM, Vivien Didelot
> <vivien.didelot@savoirfairelinux.com> wrote:
>
> > Technologic Systems TS-5500 provides digital I/O lines exposed through
> > pin blocks. On this platform, there are three of them, named DIO1, DIO2
> > and LCD port, that may be used as a DIO block.
> >
> > The TS-5500 pin blocks are described in the product's wiki:
> > http://wiki.embeddedarm.com/wiki/TS-5500#Digital_I.2FO
> >
> > This driver is not limited to the TS-5500 blocks. It can be extended to
> > support similar boards pin blocks, such as on the TS-5600.
> >
> > This patch is the V2 of the previous https://lkml.org/lkml/2012/9/25/671
> > with corrections suggested by Linus Walleij.
> >
> > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> > Signed-off-by: Jerome Oufella <jerome.oufella@savoirfairelinux.com>
>
> Thanks Vivien, it's looking *very* nice and clean now, so patch applied!
>
> It's perfectly OK this late before the merge window since it's a new driver.
>
> Yours,
> Linus Walleij
Wait a minute.... this driver looks very much like gpio-generic. It
really should be using that interface, not recreating all the gpio
infrastructure that has been done so many times before.
Please take a look at either send me a follow-on patch to convert it to
use gpio-generic, or tell my why gpio-generic isn't appropriate here.
It's already in, so I'm not got to take it back out (that wouldn't be
very fair), but I may decide to move it to staging.
g.
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
next prev parent reply other threads:[~2012-12-19 20:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-08 2:36 [PATCH v2] gpio: add TS-5500 DIO blocks support Vivien Didelot
2012-12-10 9:55 ` Linus Walleij
2012-12-19 17:16 ` Grant Likely [this message]
2012-12-19 22:13 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219171600.7B0EF3E0C5A@localhost \
--to=grant.likely@secretlab.ca \
--cc=jerome.oufella@savoirfairelinux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).