linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Myron Stowe <myron.stowe@redhat.com>
To: bhelgaas@google.com
Cc: linux-pci@vger.kernel.org, astarta@rat.ru, ddutile@redhat.com,
	james.paradis@stratus.com, matthew.r.wilcox@intel.com,
	prarit@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH] PCI: Work around Stratus ftServer broken PCIe hierarchy
Date: Wed, 19 Dec 2012 14:50:05 -0700	[thread overview]
Message-ID: <20121219215005.17785.47831.stgit@amt.stowe> (raw)

Recently, another report surfaced indicating Stratus ftServer platforms
were exhibiting similar failures as has occurred in the past [1].

  In late 2011 we started seeing issues with Stratus ftServer systems.
  The typical failure was that USB and network devices were not being
  seen.  Research uncovered that the failure was due to the platform's PCI
  Express hierarchy  not conforming to the PCI Express specification [2]
  which commit f07852d exposed.

  The following are known Stratus ftServer platforms whose PCI hierarchies
  are broken:

  Stratus ftServer ????
  +-07.0-[01-76]--+-00.0-[02-76]--+-00.0-[03-3c]--+-00.0-[04-09]..
                                                  \-01.0-[0a-0d]--+-[USB]
                                                                  +-[NIC]
                                                                  +-..

  Stratus ftServer 6400
  [0000:00]-+-...-00.0-[03]-00.0-[04]-+-00.0-[05]---00.0-[06]..
            |  |                      |
            |  |                      \-01.0-[2c]-+-00.0 [USB]
            |  |                                  +-00.1 [USB]
            |  |                                  \-1f.0 [ISA]

  Stratus ftServer 4500
  Stratus ftServer 6310

  As a solution, commit 284f5f9 was introduced.

Looking into this again it looks as if the quirk introduced in 284f5f9 is
not making the correct DMI based check.  This patch fixes the DMI 'vendor'
based check to match "Stratus", not "ftServer".  It also augments the
checking to include matching the DMI based 'product name' to "ftServer".
This quirk should now trigger for all Stratus ftServer platforms which I
was able to confirm by testing on a Stratus ftServer 6400 system with the
following 'dmidecode' output:
  System Information
        Manufacturer: Stratus
        Product Name: ftServer 6400

[1] https://bugzilla.kernel.org/show_bug.cgi?id=51331
[2] PCI Express specification, r3.0, Section 7.3.1

Reported-by: Fadeeva Marina <astarta@rat.ru>
Signed-off-by: Myron Stowe <myron.stowe@redhat.com>
---

 arch/x86/pci/common.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c
index 720e973..487d9f3 100644
--- a/arch/x86/pci/common.c
+++ b/arch/x86/pci/common.c
@@ -433,7 +433,8 @@ static const struct dmi_system_id __devinitconst pciprobe_dmi_table[] = {
 		.callback = set_scan_all,
 		.ident = "Stratus/NEC ftServer",
 		.matches = {
-			DMI_MATCH(DMI_SYS_VENDOR, "ftServer"),
+			DMI_MATCH(DMI_SYS_VENDOR, "Stratus"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "ftServer"),
 		},
 	},
 	{}


             reply	other threads:[~2012-12-19 21:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-19 21:50 Myron Stowe [this message]
2012-12-20 21:46 ` [PATCH] PCI: Work around Stratus ftServer broken PCIe hierarchy Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121219215005.17785.47831.stgit@amt.stowe \
    --to=myron.stowe@redhat.com \
    --cc=astarta@rat.ru \
    --cc=bhelgaas@google.com \
    --cc=ddutile@redhat.com \
    --cc=james.paradis@stratus.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthew.r.wilcox@intel.com \
    --cc=prarit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).