From: Grant Likely <grant.likely@secretlab.ca>
To: Joonyoung Shim <jy0922.shim@samsung.com>, linus.walleij@linaro.org
Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
kgene.kim@samsung.com, kyungmin.park@samsung.com
Subject: Re: [PATCH] gpio: samsung: remove exynos_gpio_cfg
Date: Wed, 19 Dec 2012 22:22:55 +0000 [thread overview]
Message-ID: <20121219222255.49E263E0AD6@localhost> (raw)
In-Reply-To: <1355481842-17952-1-git-send-email-jy0922.shim@samsung.com>
On Fri, 14 Dec 2012 19:44:01 +0900, Joonyoung Shim <jy0922.shim@samsung.com> wrote:
> The exynos_gpio_cfg can be substituted to samsung_gpio_cfgs[8].
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
Hi Joonyoung,
I need some help here. I don't understand what this patch is for or how
it works. The commit text above doesn't give me enough information to
evaluate the patch. What is the intent here? Why is samsung_gpio_cfgs[8]
more correct than exynos_gpio_cfg?
g.
next prev parent reply other threads:[~2012-12-19 22:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 10:44 [PATCH] gpio: samsung: remove exynos_gpio_cfg Joonyoung Shim
2012-12-14 10:44 ` [PATCH] gpio: samsung: add GPIO interrupt registration for exynos5 Joonyoung Shim
2013-01-17 8:14 ` Linus Walleij
2012-12-14 12:09 ` [PATCH] gpio: samsung: remove exynos_gpio_cfg Tomasz Figa
2012-12-19 22:22 ` Grant Likely [this message]
2012-12-20 1:13 ` Joonyoung Shim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219222255.49E263E0AD6@localhost \
--to=grant.likely@secretlab.ca \
--cc=jy0922.shim@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox