From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 2/3] perf x86: Add precise sysfs attribute
Date: Thu, 20 Dec 2012 12:19:04 +0100 [thread overview]
Message-ID: <20121220111904.GC1241@krava.brq.redhat.com> (raw)
In-Reply-To: <20121220083925.GC3679@danjae>
On Thu, Dec 20, 2012 at 05:39:25PM +0900, Namhyung Kim wrote:
> On Wed, Dec 19, 2012 at 04:07:21PM +0100, Jiri Olsa wrote:
> > Adding sysfs precise attribute for cpu device (/sys/devices/cpu)
> > to show the maximum value for perf event precise attribute.
> >
> > This will be initialy used for automated precise event perf test
> > and could be helpful otherwise. Arnaldo suggested to use this as
> > a guide for default adding of precise attribute for HW events.
>
> Although I'm not aware of which architectures support precise feature,
> wouldn't it better putting this on architecture independent rather
> than just for x86 with fallback routine returning 0?
same here.. :) no idea if there's same concept in other archs
Anyway, I'd say it's not big change so once other archs get
interested, it's easy to make it global one.
Same like for event aliases moving to ppc now:
http://marc.info/?l=linux-kernel&m=135590210618224&w=2
thanks,
jirka
next prev parent reply other threads:[~2012-12-20 11:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 15:07 [RFC 0/3] perf tests: Adding precise event attribute test Jiri Olsa
2012-12-19 15:07 ` [PATCH 1/3] Revert "perf: Require exclude_guest to use PEBS - kernel side enforcement" Jiri Olsa
2012-12-22 19:21 ` David Ahern
2012-12-24 14:03 ` Jiri Olsa
2012-12-19 15:07 ` [PATCH 2/3] perf x86: Add precise sysfs attribute Jiri Olsa
2012-12-20 5:34 ` Greg KH
2012-12-20 10:27 ` Jiri Olsa
2012-12-20 8:39 ` Namhyung Kim
2012-12-20 11:19 ` Jiri Olsa [this message]
2012-12-19 15:07 ` [PATCH 3/3] perf tests: Add precise event attribute test Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220111904.GC1241@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).