From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752117Ab2LTTJt (ORCPT ); Thu, 20 Dec 2012 14:09:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44497 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427Ab2LTTJm (ORCPT ); Thu, 20 Dec 2012 14:09:42 -0500 Date: Thu, 20 Dec 2012 14:09:23 -0500 From: Don Zickus To: Seiji Aguchi Cc: "linux-kernel@vger.kernel.org" , "Luck, Tony (tony.luck@intel.com)" , "ccross@android.com" , "keescook@chromium.org" , "cbouatmailru@gmail.com" , Satoru Moriya , "dle-develop@lists.sourceforge.net" Subject: Re: [PATCH v3 0/2] pstore,efi_pstore: Avoid deadlock in non-blocking paths Message-ID: <20121220190923.GP88797@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 20, 2012 at 03:11:14PM +0000, Seiji Aguchi wrote: > Changelog > v2 -> v3 > - Merge modifications of pstore part in 2/2 to 1/2. > - Rename pstore_is_non_blocking_path() to pstore_cannot_block_path(). > > v1 -> v2 > - Erase a logic checking the number of online cpus. > - Create a patchset to fix deadlocking issue in both pstore filesystem and > efi_pstore driver. > - Introduce a function, is_non_blocking_path(), to check if pstore > is in panic and emergency-restart paths (PATCH 1/2) > - Avoid efi_pstore_driver is blocked in non-blocking paths > such as nmi, panic and emergency-restart paths (PATCH 2/2) > > [Issue] > > There are some paths in kernel which shouldn't be blocked, > like NMI, panic case after stopping cpus, emergency-restart. I am ok with it. Acked-by: Don Zickus